Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary dependencies #209

Merged
merged 4 commits into from Sep 12, 2018
Merged

Remove unnecessary dependencies #209

merged 4 commits into from Sep 12, 2018

Conversation

@realityking
Copy link
Contributor

@realityking realityking commented Sep 11, 2018

Love the v3 release, the new output is much cleaner. Great work!

I noticed v3 pulls in a few new dependencies that aren't necessary. This PR fixes that.

  • Move those dependencies that are only used in the client to dev-dependencies. Meaning @babel/polyfill, mobx and mobx-preact. Also fixes #208.
  • Increase the target node version in the babel config to 6.14.4. There are some plug-ins that fall off when targeting >= 6.5 so this helps load less polyfills.
  • Remove transform-runtime and thus the dependency on @babel/runtime for the plugin itself (it stays around for the client). It only loaded four functions from the runtime (all related to ESM support) but brings in heavy dependencies.
  • Last but not least, adds the semver operator ^ for the dependency on lodash. It was the only one that didn't have it.
@jsf-clabot
Copy link

@jsf-clabot jsf-clabot commented Sep 11, 2018

CLA assistant check
All committers have signed the CLA.

@th0r
Copy link
Collaborator

@th0r th0r commented Sep 12, 2018

Very nice! The only suggestion is to make "@babel/runtime" a strict dependency as all other dev dependencies.

realityking added 2 commits Sep 12, 2018
The miimal size saving is not worth the extra dependencies
@realityking
Copy link
Contributor Author

@realityking realityking commented Sep 12, 2018

@th0r Ups, that wasn't intentional. Fixed.

@th0r th0r merged commit 18bc2b9 into webpack-contrib:master Sep 12, 2018
2 checks passed
@th0r
Copy link
Collaborator

@th0r th0r commented Sep 12, 2018

Thanks a lot!

@realityking realityking deleted the dependencies branch Sep 12, 2018
@th0r
Copy link
Collaborator

@th0r th0r commented Sep 12, 2018

Released in v3.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants