Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update web page title #310

Merged
merged 4 commits into from Sep 12, 2019
Merged

Update web page title #310

merged 4 commits into from Sep 12, 2019

Conversation

@gaokun
Copy link
Contributor

@gaokun gaokun commented Sep 11, 2019

What I did

1. add

add favicon.ico for web page.

2. update

update web page title.

Use project name + build time instead of Webpack Bundle Analyzer.

Why & What scene

Before:

I would leave some 'Webpack Bundle Analyzer' tabs there, to see the difference between them.

Like, the first tab is original. the second tab is packed with tree-shaking

image

But I often mix them up, coz same title.

After:

image

I use project name + build time as title that can help me to distinguish them.

In one word:

1. Icon represents this is a Webpack Bundle Analyzer page

2. Title represents which project it belongs to and the building time

PS: Feel free to change a new icon you like.

update: update web page title. Use `project name` + `build time` instead of 'Webpack Bundle Analyzer'.
@valscion
Copy link
Member

@valscion valscion commented Sep 11, 2019

Nice idea! Could you split this to two pull requests — I'm not sure about favicon as the output is no longer one HTML file after this, but also contains the favicon. I like the idea of changing the title, though 👍

@valscion
Copy link
Member

@valscion valscion commented Sep 11, 2019

It might be possible to inject the favicon as a base64 encoded data URI, so that the output would still consist of only one HTML file.

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/utils.js Outdated Show resolved Hide resolved
src/viewer.js Show resolved Hide resolved
views/viewer.ejs Outdated Show resolved Hide resolved
views/viewer.ejs Outdated Show resolved Hide resolved
webpack.config.js Outdated Show resolved Hide resolved
gaokun and others added 2 commits Sep 12, 2019
Co-Authored-By: Yuriy Grunin <grunin.ya@ya.ru>
update datetime format to : 12/Sep 14:40.
@gaokun
Copy link
Contributor Author

@gaokun gaokun commented Sep 12, 2019

@valscion glad to know u love it.

@th0r Hi, new commit pushed. Thanks for reviewing.

@gaokun gaokun requested a review from th0r Sep 12, 2019
package.json Outdated Show resolved Hide resolved
src/utils.js Outdated Show resolved Hide resolved
src/viewer.js Show resolved Hide resolved
Copy link
Collaborator

@th0r th0r left a comment

Let's better use webpack's icon. I've already optimized it.

webpack

base64:

data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAEAAAABACAMAAACdt4HsAAABrVBMVEUAAAD///////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////+O1foceMD///+J0/qK1Pr7/v8Xdr/9///W8P4UdL7L7P0Scr2r4Pyj3vwad8D5/f/2/f+55f3E6f34+/2H0/ojfMKpzOd0rNgQcb3F3O/j9f7c8v6g3Pz0/P/w+v/q+P7n9v6T1/uQ1vuE0vqLut/y+v+Z2fvt+f+15Pzv9fuc2/vR7v2V2Pvd6/bg9P7I6/285/2y4/yp3/zp8vk8i8kqgMT7/P31+fyv4vxGkcz6/P6/6P3j7vfS5PNnpNUxhcbO7f7F6v3O4vHK3/DA2u631Ouy0eqXweKJud5wqthfoNMMbLvY8f73+v2dxeR8sNtTmdDx9/zX6PSjyeaCtd1YnNGX2PuQveCGt95Nls42h8dLlM3F4vBtAAAAM3RSTlMAAyOx0/sKBvik8opWGBMOAe3l1snDm2E9LSb06eHcu5JpHbarfHZCN9CBb08zzkdNS0kYaptYAAAFV0lEQVRYw92X51/aYBDHHS2O2qqttVbrqNq9m+TJIAYIShBkWwqIiCgoWvfeq7Z2/s29hyQNyUcR7LveGwVyXy6XH8/9rqxglLfUPLxVduUor3h0rfp2TYvpivk37929TkG037hffoX0+peVtZQc1589rigVUdXS/ABSAyEmGIO/1XfvldSK8vs3OqB6u3m0nxmIrvgB0dj7rr7Y9IbuF68hnfFaiHA/sxqm0wciIG43P60qKv9WXWc1RXGh/mFESFABTSBi0sNAKzqet17eCtOb3kZIDwxEEU0oAIJGYxNBDhBND29e0rtXXbcpuPmED9IhEAAQ/AXEaF8EPmnrrKsv0LvWR3fg5sWDNAFZOgAgaKvZDogHNU9MFwnnYROkc56RD5CjAbQX9Ow4g7upCsvYu55aSI/Nj0H1akgKQEUM94dwK65hYRmFU9MIcH/fqJYOZYcnuJSU/waKDgTOEVaVKhwrTRP5XzgSpAITYzom7UvkhFX5VutmxeNnWDjjswTKTyfgluNDGbUpWissXhF3s7mlSml+czWkg3D0l1nNjGNjz3myOQOa1KM/jOS6ebdbAVTCi4gljHSFrviza7tOgRWcS0MOUX9zdNgag5w7rRqA44Lzw0hr1WqES36dFliSJFlh2rXIae3FFcDDgKdxrUIDePr8jGcSClV1u7A9xeN0ModY/pHMxmR1EzRh8TJiwqsHmKW0l4FCEZI+jHio+JdPPE9qwQtTRxku2D8sIeRL2LnxWSllANCQGOIiqVHAz2ye2JR0DcH+HoxDkaADLjgxjKQ+AwCX/g0+DNgdG0ukYCONAe+dbc2IAc6fwt1ARoDSezNHxV2Cmzwv3O6lDMV55edBGwGK9n1+x2F8EDfAGCxug8MhpsMEcTEAWf3rx2vZhe/LAmtIn/6apE6PN0ULKgywD9mmdxbmFl3OvD5AS5fW5zLbv/YHmcsBTjf/afDz3MaZTVCfAP9z6/Bw6ycv8EUBWJIn9zYcoAWWlW9+OzO3vkTy8H+RANLmdrpOuYWdZYEXpo+TlCJrW5EARb7fF+bWdqf3hhyZI1nWJQHgznErZhbjoEsWqi8dQNoE294aldzFurwSABL2XXMf9+H1VQGke9exw5P/AnA5Pv5ngMul7LOvO922iwACu8WkCwLCafvM4CeWPxfA8lNHcWZSoi8EwMAIciKX2Z4SWCMAa3snCZ/G4EA8D6CMLNFsGQhkkz/gQNEBbPCbWsxGUpYVu3z8IyNAknwJkfPMEhLyrdi5RTyUVACkw4GSFRNWJNEW+fgPGwHD8/JxnRuLabN4CGNRkAE23na2+VmEAUmrYymSGjMAYqH84YUIyzgzs3XC7gNgH36Vcc4zKY9o9fgPBXUAiHHwVboBHGLiX6Zcjp1f2wu4tvzZKo0ecPnDtQYDQvJXaBeNzce45Fp28ZQLrEZVuFqgBwOalArKXnW1UzlnSusQKJqKYNuz4tOnI6sZG4zanpemv+7ySU2jbA9h6uhcgpfy6G2PahirDZ6zvq6zDduMVFTKvzw8wgyEdelwY9in3XkEPs3osJuwRQ4qTkfzifndg9Gfc4pdsu82+tTnHZTBa2EAMrqr2t43pguc8tNm7JQVQ2S0ukj2d22dhXYP0/veWtwKrCkNoNimAN5+Xr/oLrxswKbVJjteWrX7eR63o4j9q0GxnaBdWgGA5VStpanIjQmEhV0/nVt5VOFUvix6awJhPcAaTEShgrG+iGyvb5a0Ndb1YGHFPEwoqAinoaykaID1o1pdPNu7XsnCKQ3R+hwWIIhGvORcJUBYXe3Xa3vq/mF/N9V13ugufMkfXn+KHsRD0B8AAAAASUVORK5CYII=
use webpack icon as favicon.
update datetime format to : 12 Sep 2019 at 14:40.
withdraw mocha version change.
@gaokun
Copy link
Contributor Author

@gaokun gaokun commented Sep 12, 2019

For now, this PR is quite simple & clear.
It does not change npm packages.

Just add base64 icon and update title.

@th0r
Copy link
Collaborator

@th0r th0r commented Sep 12, 2019

Great, thanks! Let me double-check that it works like expected and I'll merge it.

@gaokun
Copy link
Contributor Author

@gaokun gaokun commented Sep 12, 2019

Thanks, glad to help.
I love this plugin.
I have been working on webpack optimization of my project these days, it helps a lot. ^_^

@th0r th0r merged commit c9c8998 into webpack-contrib:master Sep 12, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@th0r
Copy link
Collaborator

@th0r th0r commented Sep 12, 2019

Published in v3.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.