From 5d21a03c290fd5c8c0247e63c4bc7419862323dd Mon Sep 17 00:00:00 2001 From: Anton Vynogradenko Date: Wed, 2 Mar 2016 00:17:34 -0800 Subject: [PATCH 1/2] remvoing REM use from "lineHeight" property REMs are units relative to a viewport's font size, so if it's set to a small one (like 8px) overlay would have lines jumping over each other --- client-overlay.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client-overlay.js b/client-overlay.js index 02562f3..e8bab08 100644 --- a/client-overlay.js +++ b/client-overlay.js @@ -5,7 +5,7 @@ var styles = { display: 'none', background: 'rgba(0,0,0,0.85)', color: '#E8E8E8', - lineHeight: '1.2rem', + lineHeight: '1.2', whiteSpace: 'pre', fontFamily: 'Menlo, Consolas, monospace', fontSize: '13px', From 0aa886e430d4e530ec5c3deec93f506fe8c03bc4 Mon Sep 17 00:00:00 2001 From: Anton Vynogradenko Date: Wed, 2 Mar 2016 12:20:57 -0800 Subject: [PATCH 2/2] changing margin bottom to absolute "px" to be predictable --- client-overlay.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client-overlay.js b/client-overlay.js index e8bab08..1f7effd 100644 --- a/client-overlay.js +++ b/client-overlay.js @@ -51,7 +51,7 @@ function showProblems(type, lines) { lines.forEach(function(msg) { msg = ansiHTML(entities.encode(msg)); var div = document.createElement('div'); - div.style.marginBottom = '2rem'; + div.style.marginBottom = '26px'; div.innerHTML = problemType(type) + ' in ' + msg; clientOverlay.appendChild(div); });