Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): actually use graceful-fs #262

Merged
merged 2 commits into from Nov 20, 2020
Merged

chore(deps): actually use graceful-fs #262

merged 2 commits into from Nov 20, 2020

Conversation

AviVahl
Copy link
Contributor

@AviVahl AviVahl commented Nov 3, 2020

Usage was removed at #182

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

Copy link
Member

@sokra sokra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

I think it was a mistake that this was removed.

This line

const fs = require("fs");

should require graceful-fs instead.

Do you want to change that? Also update graceful-fs to the latest version if possible.

@webpack-bot
Copy link

@AviVahl Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@sokra Please review the new changes.

@AviVahl AviVahl changed the title chore(deps): remove unused graceful-fs chore(deps): actually use graceful-fs Nov 4, 2020
@AviVahl
Copy link
Contributor Author

AviVahl commented Nov 4, 2020

I changed it back per @sokra's comment.

TBH, as a standalone library, I would have expected enhanced-resolve to not use/require graceful-fs by default...
When used in webpack, it could have provided it with its own copy of graceful-fs... (via the fileSystem option)

@alexander-akait
Copy link
Member

Yep, we can improve it, but let's it do in the separate PR

@AviVahl
Copy link
Contributor Author

AviVahl commented Nov 20, 2020

@sokra this is ready for a merge, I guess...?

@sokra sokra merged commit 1489524 into webpack:master Nov 20, 2020
@sokra
Copy link
Member

sokra commented Nov 20, 2020

yes

@sokra
Copy link
Member

sokra commented Nov 20, 2020

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants