New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): actually use graceful-fs #262
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch.
I think it was a mistake that this was removed.
This line
Line 8 in d6807b5
const fs = require("fs"); |
should require graceful-fs instead.
Do you want to change that? Also update graceful-fs to the latest version if possible.
I changed it back per @sokra's comment. TBH, as a standalone library, I would have expected enhanced-resolve to not use/require |
Yep, we can improve it, but let's it do in the separate PR |
@sokra this is ready for a merge, I guess...? |
yes |
thanks |
Usage was removed at #182