diff --git a/README.md b/README.md index 83346c6..34443d2 100644 --- a/README.md +++ b/README.md @@ -115,6 +115,21 @@ loaderUtils.stringifyRequest(this, "\\\\network-drive\\test.js"); Converts some resource URL to a webpack module request. +> i Before call `urlToRequest` you need call `isUrlRequest` to ensure it is requestable url + +```javascript +const url = "path/to/module.js"; + +if (loaderUtils.isUrlRequest(url)) { + // Logic for requestable url + const request = loaderUtils.urlToRequest(url); +} else { + // Logic for not requestable url +} +``` + +Simple example: + ```javascript const url = "path/to/module.js"; const request = loaderUtils.urlToRequest(url); // "./path/to/module.js" diff --git a/lib/urlToRequest.js b/lib/urlToRequest.js index 597115f..e2b60d3 100644 --- a/lib/urlToRequest.js +++ b/lib/urlToRequest.js @@ -41,9 +41,6 @@ function urlToRequest(url, root) { '.' ); } - } else if (/^(?:https?:)?\/\//.test(url)) { - // Preserve http and https urls - request = url; } else if (/^\.\.?\//.test(url)) { // A relative url stays request = url; diff --git a/test/urlToRequest.test.js b/test/urlToRequest.test.js index f7160f2..2d9a17e 100644 --- a/test/urlToRequest.test.js +++ b/test/urlToRequest.test.js @@ -13,9 +13,6 @@ ExpectedError.prototype.matches = function(err) { describe('urlToRequest()', () => { [ // without root - [['//google.com'], '//google.com', 'should handle scheme-agnostic urls'], - [['http://google.com'], 'http://google.com', 'should handle http urls'], - [['https://google.com'], 'https://google.com', 'should handle https urls'], [ ['path/to/thing'], './path/to/thing',