From 07833c0889843a725f385841ac5a91f2a35c7448 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dominykas=20Bly=C5=BE=C4=97?= Date: Sun, 16 May 2021 18:38:16 +0300 Subject: [PATCH 1/2] ci: fix typo in lint matrix setup `env.node-version` was undefined (`matrix.node-version` was defined, but never used), therefore the linting used to run in Node.js 14 --- .github/workflows/nodejs.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index 1deaa3b6..d9f37881 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -20,7 +20,7 @@ jobs: strategy: matrix: os: [ubuntu-latest] - node-version: [12.x] + node-version: [14.x] runs-on: ${{ matrix.os }} @@ -29,10 +29,10 @@ jobs: with: fetch-depth: 0 - - name: Use Node.js ${{ env.node-version }} + - name: Use Node.js ${{ matrix.node-version }} uses: actions/setup-node@v1 with: - node-version: ${{ env.node-version }} + node-version: ${{ matrix.node-version }} - name: Use latest NPM run: sudo npm i -g npm From 6dda685c42383debdf7d4d05ede4f505cd19bc26 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dominykas=20Bly=C5=BE=C4=97?= Date: Mon, 17 May 2021 15:39:52 +0300 Subject: [PATCH 2/2] ci: lint in node 12 (earliest LTS) --- .github/workflows/nodejs.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index d9f37881..625b8b0c 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -20,7 +20,7 @@ jobs: strategy: matrix: os: [ubuntu-latest] - node-version: [14.x] + node-version: [12.x] runs-on: ${{ matrix.os }}