From 2ae99c2a878d785e0959bb59e7dee90386b02c39 Mon Sep 17 00:00:00 2001 From: Nitin Kumar Date: Tue, 10 Nov 2020 17:39:36 +0530 Subject: [PATCH] tests: fix (#2092) --- test/env/array/array-env.test.js | 12 +++++++----- test/env/array/webpack.config.js | 4 ++-- test/env/object/object-env.test.js | 10 ++++++---- 3 files changed, 15 insertions(+), 11 deletions(-) diff --git a/test/env/array/array-env.test.js b/test/env/array/array-env.test.js index 2b4f7b4ba1c..90c3707162d 100644 --- a/test/env/array/array-env.test.js +++ b/test/env/array/array-env.test.js @@ -4,7 +4,7 @@ const path = require('path'); const execa = require('execa'); const { sync: spawnSync } = execa; -const { run } = require('../../utils/test-utils'); +const { run, isWebpack5 } = require('../../utils/test-utils'); const devFile = path.join(__dirname, './bin/dev.js'); const prodFile = path.join(__dirname, './bin/prod.js'); @@ -17,10 +17,12 @@ describe('env array', () => { expect(stderr).toBeFalsy(); expect(stdout).toBeTruthy(); - const devScript = spawnSync('node', [devFile]); - const prodScript = spawnSync('node', [prodFile]); + if (isWebpack5) { + const devScript = spawnSync('node', [devFile]); + const prodScript = spawnSync('node', [prodFile]); - expect(devScript.stdout).toBe('environment is development'); - expect(prodScript.stdout).toBe('environment is production'); + expect(devScript.stdout).toBe('environment is development'); + expect(prodScript.stdout).toBe('environment is production'); + } }); }); diff --git a/test/env/array/webpack.config.js b/test/env/array/webpack.config.js index 013ab0a133b..ec67e7da042 100644 --- a/test/env/array/webpack.config.js +++ b/test/env/array/webpack.config.js @@ -3,7 +3,7 @@ const webpack = require('webpack'); module.exports = [ { output: { - filename: './prod.js', + filename: 'prod.js', }, mode: 'production', devtool: 'eval-cheap-module-source-map', @@ -16,7 +16,7 @@ module.exports = [ }, { output: { - filename: './dev.js', + filename: 'dev.js', }, mode: 'development', target: 'node', diff --git a/test/env/object/object-env.test.js b/test/env/object/object-env.test.js index b5a3a5878f6..2365e4c3ea8 100644 --- a/test/env/object/object-env.test.js +++ b/test/env/object/object-env.test.js @@ -4,7 +4,7 @@ const path = require('path'); const execa = require('execa'); const { sync: spawnSync } = execa; -const { run } = require('../../utils/test-utils'); +const { run, isWebpack5 } = require('../../utils/test-utils'); describe('env object', () => { it('is able to set env for an object', () => { @@ -14,8 +14,10 @@ describe('env object', () => { expect(stderr).toBeFalsy(); expect(stdout).toBeTruthy(); - const executable = path.join(__dirname, './bin/main.js'); - const bundledScript = spawnSync('node', [executable]); - expect(bundledScript.stdout).toBe('environment is development'); + if (isWebpack5) { + const executable = path.join(__dirname, './bin/main.js'); + const bundledScript = spawnSync('node', [executable]); + expect(bundledScript.stdout).toBe('environment is development'); + } }); });