Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix webpack hanging under certain circumstance #1078

Merged
merged 1 commit into from Sep 17, 2019

Conversation

lneveu
Copy link
Contributor

@lneveu lneveu commented Sep 13, 2019

What kind of change does this PR introduce?
Bugfix

Did you add tests for your changes?
No

If relevant, did you update the documentation?
Not required

Summary

This pull request is similar to this one: webpack/webpack#6193 merged two years ago, but in Webpack main repository.
It fixes this issue: webpack-contrib/sass-loader#759

See the previous pull request for more details.

Related issues:
nodejs/node#17872
webpack-contrib/sass-loader#523

Does this PR introduce a breaking change?
No

@jsf-clabot
Copy link

jsf-clabot commented Sep 13, 2019

CLA assistant check
All committers have signed the CLA.

@webpack-bot
Copy link

webpack-bot commented Sep 13, 2019

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

Copy link
Member

@evenstensberg evenstensberg left a comment

lgtm

@evenstensberg evenstensberg merged commit a1341bd into webpack:master Sep 17, 2019
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants