Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new no-cache flag and patch sec dep #1102

Merged
merged 1 commit into from Oct 31, 2019
Merged

Conversation

@evenstensberg
Copy link
Member

evenstensberg commented Oct 27, 2019

What kind of change does this PR introduce?
Fixes #1095

Did you add tests for your changes?
N/A
If relevant, did you update the documentation?
No, this needs to be done
Summary
Adds no-cache flag, (we do not check version here for setting the property)

Does this PR introduce a breaking change?
No
Other information

  • Might need to add validation against webpack version?
  • Monorepo test are failing, might worth removing the entire mono repo at master branch? (Is that good for versioning against next? I think it's bad)
@evenstensberg evenstensberg changed the title feat: add new flag and patch sec dep feat: add new no-cache flag and patch sec dep Oct 27, 2019
@webpack-bot
Copy link

webpack-bot commented Oct 27, 2019

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

Copy link
Contributor

ematipico left a comment

At this point why don't take the leap and release the v4 and dropping support for webpack v4?

Cli v4 will support only webpack v5

@evenstensberg
Copy link
Member Author

evenstensberg commented Oct 27, 2019

That would be great, but we need to write docs, migration guide and make sure it is stable

@evenstensberg evenstensberg merged commit 1208aa6 into master Oct 31, 2019
13 checks passed
13 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
commitlint found 0 problems, 0 warnings
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
security/snyk - package.json (evenstensberg) No new issues
Details
webpack.webpack-cli Build #20191027.1 succeeded
Details
webpack.webpack-cli (Linux node-10) Linux node-10 succeeded
Details
webpack.webpack-cli (Linux node-12) Linux node-12 succeeded
Details
webpack.webpack-cli (Linux node-8) Linux node-8 succeeded
Details
webpack.webpack-cli (macOS node-10) macOS node-10 succeeded
Details
webpack.webpack-cli (macOS node-12) macOS node-12 succeeded
Details
webpack.webpack-cli (macOS node-8) macOS node-8 succeeded
Details
@evenstensberg evenstensberg deleted the feat/no-cache-flag branch Oct 31, 2019
@anikethsaha
Copy link
Member

anikethsaha commented Oct 31, 2019

Cli v4 will support only webpack v5

webpack v5 is in beta, isn't it ?
Why removing support for v4? I guess many projects will still be using webpack.v4 for quite a few time in the future. cause I still see projects using v2.
Will it be like webpack-cli v3 will be for webpack v4 and less ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.