Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(templates): Branding guide violation fix #1226

Merged
merged 3 commits into from Feb 16, 2020

Conversation

@wizardofhogwarts
Copy link

wizardofhogwarts commented Feb 16, 2020

No description provided.

Copy link
Member

rishabh3112 left a comment

Hi @wizardofhogwarts!
Please change title such that it suggests branding guide violation.
Also left a suggestion.

packages/generators/templates/template.html Outdated Show resolved Hide resolved
@wizardofhogwarts
Copy link
Author

wizardofhogwarts commented Feb 16, 2020

Hi @wizardofhogwarts!
Please change title such that it suggests branding guide violation.
Also left a suggestion.

@rishabh3112 Can you please suggest a title

@webpack-bot
Copy link

webpack-bot commented Feb 16, 2020

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@webpack-bot
Copy link

webpack-bot commented Feb 16, 2020

@wizardofhogwarts Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@rishabh3112 Please review the new changes.

@wizardofhogwarts wizardofhogwarts requested a review from rishabh3112 Feb 16, 2020
Copy link
Contributor

anshumanv left a comment

Commitlint is failing, can you amend your commit or commit using npm run commit?

@wizardofhogwarts wizardofhogwarts changed the title docs(templates): Grammatical fixes docs(templates): Branding guide violation fix Feb 16, 2020
@wizardofhogwarts
Copy link
Author

wizardofhogwarts commented Feb 16, 2020

Hi @wizardofhogwarts!
Please change title such that it suggests branding guide violation.
Also left a suggestion.

@rishabh3112 Can you please suggest a title

@rishabh3112 I have changed the title

Co-Authored-By: Rishabh Chawla <rishabh31121999@gmail.com>
@rishabh3112 rishabh3112 force-pushed the wizardofhogwarts:patch-1 branch from 5a25947 to 6d45310 Feb 16, 2020
@webpack webpack deleted a comment from commitlint bot Feb 16, 2020
@webpack webpack deleted a comment from commitlint bot Feb 16, 2020
@ematipico ematipico merged commit ab910df into webpack:master Feb 16, 2020
9 checks passed
9 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
commitlint found 0 problems, 0 warnings
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
security/snyk - package.json (evenstensberg) No manifest changes detected
webpack.webpack-cli Build #20200216.4 succeeded
Details
webpack.webpack-cli (Linux node-10) Linux node-10 succeeded
Details
webpack.webpack-cli (Linux node-12) Linux node-12 succeeded
Details
webpack.webpack-cli (Linux node-8) Linux node-8 succeeded
Details
@wizardofhogwarts wizardofhogwarts deleted the wizardofhogwarts:patch-1 branch Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.