Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove v8-compile-cache #3006

Merged
merged 2 commits into from Oct 18, 2021
Merged

fix: remove v8-compile-cache #3006

merged 2 commits into from Oct 18, 2021

Conversation

@anshumanv
Copy link
Member

@anshumanv anshumanv commented Oct 17, 2021

What kind of change does this PR introduce?
Fix

Did you add tests for your changes?
Not yet

If relevant, did you update the documentation?
NA

Summary
Removes v8-compile-cache package which creates problems while using with ESM

Does this PR introduce a breaking change?
no, initiation time will be slightly more

Other information
Fix #3005

@@ -246,7 +246,6 @@ class WebpackCLI {
} catch (error) {
let previousModuleCompile;

// TODO Workaround https://github.com/zertosh/v8-compile-cache/issues/30
if (this._originalModuleCompile) {
Copy link
Member Author

@anshumanv anshumanv Oct 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me also remove this workaround logic

@codecov
Copy link

@codecov codecov bot commented Oct 17, 2021

Codecov Report

Merging #3006 (a51fadd) into master (817c9e8) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3006      +/-   ##
==========================================
- Coverage   94.89%   94.86%   -0.04%     
==========================================
  Files          22       22              
  Lines        1625     1615      -10     
  Branches      482      480       -2     
==========================================
- Hits         1542     1532      -10     
  Misses         83       83              
Impacted Files Coverage Δ
packages/webpack-cli/lib/webpack-cli.js 95.68% <ø> (-0.03%) ⬇️
packages/webpack-cli/bin/cli.js 85.71% <100.00%> (-4.29%) ⬇️
packages/webpack-cli/lib/bootstrap.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7080a20...a51fadd. Read the comment docs.

Copy link
Member

@rishabh3112 rishabh3112 left a comment

Looks good to me.

@anshumanv anshumanv marked this pull request as ready for review Oct 18, 2021
@anshumanv anshumanv requested a review from as a code owner Oct 18, 2021
@alexander-akait alexander-akait merged commit 6a9aac9 into master Oct 18, 2021
46 of 47 checks passed
@alexander-akait alexander-akait deleted the rm-v8 branch Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants