Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: failOnWarnings option #3317

Merged
merged 8 commits into from Jun 30, 2022
Merged

feat: failOnWarnings option #3317

merged 8 commits into from Jun 30, 2022

Conversation

rishabh3112
Copy link
Member

@rishabh3112 rishabh3112 commented Jun 29, 2022

What kind of change does this PR introduce?
feature

Did you add tests for your changes?
Yes

If relevant, did you update the documentation?
Done

Summary
adds --fail-on-warnings option
closes #3315

Does this PR introduce a breaking change?
No

Other information
#3315

@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #3317 (aaa1d84) into master (28b4403) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3317   +/-   ##
=======================================
  Coverage   92.09%   92.09%           
=======================================
  Files          23       23           
  Lines        1733     1733           
  Branches      519      519           
=======================================
  Hits         1596     1596           
  Misses        137      137           
Impacted Files Coverage Δ
packages/webpack-cli/src/webpack-cli.ts 93.96% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28b4403...aaa1d84. Read the comment docs.

@rishabh3112 rishabh3112 marked this pull request as ready for review June 29, 2022 05:33
@rishabh3112 rishabh3112 requested a review from a team as a code owner June 29, 2022 05:33
packages/webpack-cli/src/webpack-cli.ts Outdated Show resolved Hide resolved
@webpack-bot
Copy link

@rishabh3112 Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@vankop Please review the new changes.

vankop
vankop approved these changes Jun 29, 2022
@rishabh3112 rishabh3112 merged commit c48c848 into master Jun 30, 2022
20 checks passed
@rishabh3112 rishabh3112 deleted the feat/fail-on-warnings branch June 30, 2022 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new option to terminate with non-zero code if builded with warnings
6 participants