Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show all CLI specific flags in the minimum help output #3354

Merged
merged 2 commits into from Jul 29, 2022

Conversation

snitin315
Copy link
Member

What kind of change does this PR introduce?
bugfix

Did you add tests for your changes?
Yes. Updated snapshots.

If relevant, did you update the documentation?
No.

Summary

webpack-cli offers many additional flags like (--analyze, --json, --env, etc) than pure configuration option (like --stats, --target).

The minimum help output should contain all the additional feature flags webpack-cli offers for better visibility, It's easy to miss these flags in the verbose help output.

Does this PR introduce a breaking change?
No

Other information
NO

@snitin315 snitin315 requested a review from a team as a code owner July 29, 2022 09:30
@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

Merging #3354 (f52397b) into next (0dba3db) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #3354   +/-   ##
=======================================
  Coverage   90.83%   90.83%           
=======================================
  Files          22       22           
  Lines        1669     1670    +1     
  Branches      479      479           
=======================================
+ Hits         1516     1517    +1     
  Misses        153      153           
Impacted Files Coverage Δ
packages/webpack-cli/src/webpack-cli.ts 95.17% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dba3db...f52397b. Read the comment docs.

@alexander-akait alexander-akait merged commit 36a59d8 into next Jul 29, 2022
16 checks passed
@alexander-akait alexander-akait deleted the fix/minimum-help-output branch July 29, 2022 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants