From dff39a1c4b7c74fb76b1f55e5e44f1c578810132 Mon Sep 17 00:00:00 2001 From: Josh Goldberg Date: Mon, 8 Jul 2019 14:25:20 -0500 Subject: [PATCH] fix: directly used mkdirp instead of through Webpack (#436) Fixes Webpack 5 usage by no longer requiring the removed webpack/lib/node/NodeOutputFileSystem --- lib/fs.js | 4 +--- package-lock.json | 4 +--- package.json | 1 + 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/lib/fs.js b/lib/fs.js index 59d23db74..f230f0367 100644 --- a/lib/fs.js +++ b/lib/fs.js @@ -4,13 +4,11 @@ const fs = require('fs'); const path = require('path'); const MemoryFileSystem = require('memory-fs'); +const mkdirp = require('mkdirp'); const { colors } = require('webpack-log'); -const NodeOutputFileSystem = require('webpack/lib/node/NodeOutputFileSystem'); const DevMiddlewareError = require('./DevMiddlewareError'); -const { mkdirp } = new NodeOutputFileSystem(); - module.exports = { toDisk(context) { const compilers = context.compiler.compilers || [context.compiler]; diff --git a/package-lock.json b/package-lock.json index 7927696f3..181890bbd 100644 --- a/package-lock.json +++ b/package-lock.json @@ -8540,8 +8540,7 @@ "minimist": { "version": "0.0.8", "resolved": "https://registry.npmjs.org/minimist/-/minimist-0.0.8.tgz", - "integrity": "sha1-hX/Kv8M5fSYluCKCYuhqp6ARsF0=", - "dev": true + "integrity": "sha1-hX/Kv8M5fSYluCKCYuhqp6ARsF0=" }, "minimist-options": { "version": "3.0.2", @@ -8610,7 +8609,6 @@ "version": "0.5.1", "resolved": "https://registry.npmjs.org/mkdirp/-/mkdirp-0.5.1.tgz", "integrity": "sha1-MAV0OOrGz3+MR2fzhkjWaX11yQM=", - "dev": true, "requires": { "minimist": "0.0.8" } diff --git a/package.json b/package.json index 7b2eea355..1159059e5 100644 --- a/package.json +++ b/package.json @@ -33,6 +33,7 @@ "dependencies": { "memory-fs": "^0.4.1", "mime": "^2.4.2", + "mkdirp": "^0.5.1", "range-parser": "^1.2.1", "webpack-log": "^2.0.0" },