refactor: code #482
Merged
refactor: code #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After this PR i will start rewriting logger on webpack logger |
Codecov Report
@@ Coverage Diff @@
## master #482 +/- ##
=======================================
Coverage 97.21% 97.21%
=======================================
Files 13 13
Lines 323 323
Branches 99 99
=======================================
Hits 314 314
Misses 9 9
Continue to review full report at Codecov.
|
hiroppy
reviewed
Oct 4, 2019
.eslintignore
Outdated
| /coverage | ||
| /dist | ||
| /node_modules | ||
| /test/fixtures |
.prettierignore
Outdated
| /dist | ||
| /node_modules | ||
| /test/fixtures | ||
| CHANGELOG.md |
| "test:watch": "npm run test:only --watch", | ||
| "test:only": "cross-env NODE_ENV=test jest", | ||
| "test:watch": "cross-env NODE_ENV=test jest --watch", | ||
| "test:coverage": "cross-env NODE_ENV=test jest --collectCoverageFrom=\"lib/**/*.js\" --coverage", |
There was a problem hiding this comment.
It is better to separate to jest.config.js?
There was a problem hiding this comment.
I think it is more simple than using jest.config.js. Maybe we revisit this in future.
alexander-akait
force-pushed
the
refactor-part-4
branch
from
31723aa
to
ba30e47
Compare
hiroppy
approved these changes
Oct 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
index.jsinside lib (let's do not mix configuration files in root with code)'use strict'in some placesBreaking Changes
No
Additional Info
No