Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webpack 5 install 'url' and 'events' as a dependency #1598

Closed
1 of 2 tasks
debs-obrien opened this issue Dec 12, 2018 · 2 comments · Fixed by #1599
Closed
1 of 2 tasks

webpack 5 install 'url' and 'events' as a dependency #1598

debs-obrien opened this issue Dec 12, 2018 · 2 comments · Fixed by #1599

Comments

@debs-obrien
Copy link
Member

@debs-obrien debs-obrien commented Dec 12, 2018

  • Operating System: Mac OS
  • Node Version: v10.11.0
  • NPM Version: 6.4.1
  • webpack Version: 5
  • webpack-dev-server Version: 3.1.10
  • This is a bug
  • This is a modification request

Code

  // webpack.config.js
var path = require('path');

module.exports = {
    //...
    devServer: {
        contentBase: path.join(__dirname, 'dist'),
        compress: true,
        port: 9000,
    },
    resolve: {
        alias: {
            'url': false,
            'events' : false
        }
    }
};

Expected Behavior

Actual Behavior

BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
This is no longer the case. Verify if you need these module and configure a polyfill for it.

If you want to include a polyfill, you need to install 'url'.
If you don't want to include a polyfill, you can use an empty module like this:
        resolve.alias: { "url": false }

ERROR in (webpack)/hot/emitter.js 1:19-36
Module not found: Error: Can't resolve 'events' in '/Users/debbieobrien/webpack/node_modules/webpack/hot'

BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
This is no longer the case. Verify if you need these module and configure a polyfill for it.

If you want to include a polyfill, you need to install 'events'.
If you don't want to include a polyfill, you can use an empty module like this:
        resolve.alias: { "events": false }
 @ (webpack)-dev-server/client?http://localhost:9000 226:21-51
ℹ 「wdm」: Failed to compile.

after adding the alias to the webpack.config I get this error

 「wds」: Invalid configuration object. Webpack has been initialised using a configuration object that does not match the API schema.
 - configuration.resolve.alias should be one of these:
   object { <key>: string } | [object { alias?, name?, onlyModule? }]
   -> Redirect module requests
   Details:
    * configuration.resolve.alias['url'] should be a string.
      -> New request
    * configuration.resolve.alias['events'] should be a string.
      -> New request
    * configuration.resolve.alias should be an array:
      [object { alias?, name?, onlyModule? }]

For Bugs; How can we reproduce the behavior?

Run the webpack-dev-server in next branch

For Features; What is the motivation and/or use-case for the feature?

@debs-obrien debs-obrien changed the title webpack 5 Breaking Change webpack 5 install 'url' and 'events' as a dependency Dec 12, 2018
@TheLarkInn
Copy link
Member

@TheLarkInn TheLarkInn commented Dec 12, 2018

This is a good second timer issue to PR.

It can be a pain because you have to:
Clone, make change, build, then yarn link, and then link locally in a webpack 5 project but since fix is the easy part I'll mark this as Help Wanted

@glenjamin
Copy link
Contributor

@glenjamin glenjamin commented Dec 13, 2018

The fix for events needs to go into webpack itself, see webpack/webpack#8494

glenjamin added a commit to glenjamin/webpack-dev-server that referenced this issue Dec 13, 2018
matheus1lva pushed a commit to matheus1lva/GrCartuchos that referenced this issue Dec 21, 2018
## The devDependency [webpack-dev-server](https://github.com/webpack/webpack-dev-server) was updated from `3.1.10` to `3.1.11`.
This version is **not covered** by your **current version range**.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

---

<details>
<summary>Release Notes for v3.1.11</summary>

<p><a name="user-content-3.1.11"></a></p>
<h2><a href="https://urls.greenkeeper.io/webpack/webpack-dev-server/compare/v3.1.10...v3.1.11">3.1.11</a> (2018-12-21)</h2>
<h3>Bug Fixes</h3>
<ul>
<li><strong>bin/options:</strong> correct check for color support (<code>options.color</code>) (<a href="https://urls.greenkeeper.io/webpack/webpack-dev-server/issues/1555" data-hovercard-type="pull_request" data-hovercard-url="/webpack/webpack-dev-server/pull/1555/hovercard">#1555</a>) (<a href="https://urls.greenkeeper.io/webpack/webpack-dev-server/commit/55398b5">55398b5</a>)</li>
<li><strong>package:</strong> update <code>spdy</code> v3.4.1...4.0.0 (assertion error) (<a href="https://urls.greenkeeper.io/webpack/webpack-dev-server/issues/1491" data-hovercard-type="issue" data-hovercard-url="/webpack/webpack-dev-server/issues/1491/hovercard">#1491</a>) (<a href="https://urls.greenkeeper.io/webpack/webpack-dev-server/issues/1563" data-hovercard-type="pull_request" data-hovercard-url="/webpack/webpack-dev-server/pull/1563/hovercard">#1563</a>) (<a href="https://urls.greenkeeper.io/webpack/webpack-dev-server/commit/7a3a257">7a3a257</a>)</li>
<li><strong>Server:</strong> correct <code>node</code> version checks (<a href="https://urls.greenkeeper.io/webpack/webpack-dev-server/issues/1543" data-hovercard-type="pull_request" data-hovercard-url="/webpack/webpack-dev-server/pull/1543/hovercard">#1543</a>) (<a href="https://urls.greenkeeper.io/webpack/webpack-dev-server/commit/927a2b3">927a2b3</a>)</li>
<li><strong>Server:</strong> mime type for wasm in contentBase directory (<a href="https://urls.greenkeeper.io/webpack/webpack-dev-server/issues/1575" data-hovercard-type="issue" data-hovercard-url="/webpack/webpack-dev-server/issues/1575/hovercard">#1575</a>) (<a href="https://urls.greenkeeper.io/webpack/webpack-dev-server/issues/1580" data-hovercard-type="pull_request" data-hovercard-url="/webpack/webpack-dev-server/pull/1580/hovercard">#1580</a>) (<a href="https://urls.greenkeeper.io/webpack/webpack-dev-server/commit/fadae5d">fadae5d</a>)</li>
<li>add url for compatibility with webpack@5 (<a href="https://urls.greenkeeper.io/webpack/webpack-dev-server/issues/1598" data-hovercard-type="issue" data-hovercard-url="/webpack/webpack-dev-server/issues/1598/hovercard">#1598</a>) (<a href="https://urls.greenkeeper.io/webpack/webpack-dev-server/issues/1599" data-hovercard-type="pull_request" data-hovercard-url="/webpack/webpack-dev-server/pull/1599/hovercard">#1599</a>) (<a href="https://urls.greenkeeper.io/webpack/webpack-dev-server/commit/68dd49a">68dd49a</a>)</li>
<li>check origin header for websocket connection (<a href="https://urls.greenkeeper.io/webpack/webpack-dev-server/issues/1603" data-hovercard-type="pull_request" data-hovercard-url="/webpack/webpack-dev-server/pull/1603/hovercard">#1603</a>) (<a href="https://urls.greenkeeper.io/webpack/webpack-dev-server/commit/b3217ca">b3217ca</a>)</li>
</ul>
</details>

<details>
<summary>Commits</summary>
<p>The new version differs by 9 commits.</p>
<ul>
<li><a href="https://urls.greenkeeper.io/webpack/webpack-dev-server/commit/ff2874f5f3a90e5727434cc10f69ac4d54896033"><code>ff2874f</code></a> <code>chore(release): 3.1.11</code></li>
<li><a href="https://urls.greenkeeper.io/webpack/webpack-dev-server/commit/b3217ca8dc6b371a160b6749b949ab09d7b9f6d7"><code>b3217ca</code></a> <code>fix: check origin header for websocket connection (#1603)</code></li>
<li><a href="https://urls.greenkeeper.io/webpack/webpack-dev-server/commit/68dd49a5e44b270061e4746b2e01bbc72589ca3b"><code>68dd49a</code></a> <code>fix: add url for compatibility with webpack@5 (#1598) (#1599)</code></li>
<li><a href="https://urls.greenkeeper.io/webpack/webpack-dev-server/commit/fadae5da6ba0261cade08164feeaad99b1de6b79"><code>fadae5d</code></a> <code>fix(Server): mime type for wasm in contentBase directory (#1575) (#1580)</code></li>
<li><a href="https://urls.greenkeeper.io/webpack/webpack-dev-server/commit/7a3a2579179b2ca0fd91405d9872ba2c3ed8db3a"><code>7a3a257</code></a> <code>fix(package): update <code>spdy</code> v3.4.1...4.0.0 (assertion error) (#1491) (#1563)</code></li>
<li><a href="https://urls.greenkeeper.io/webpack/webpack-dev-server/commit/1fe82dee4eef600946b2601a2d853cffbe65db0a"><code>1fe82de</code></a> <code>ci(travis): Node 11 (on OS X) crashes, use 10 for now (#1588)</code></li>
<li><a href="https://urls.greenkeeper.io/webpack/webpack-dev-server/commit/55398b5de17b9a845b1ee5aaa90bb2002c25ddfb"><code>55398b5</code></a> <code>fix(bin/options): correct check for color support (<code>options.color</code>) (#1555)</code></li>
<li><a href="https://urls.greenkeeper.io/webpack/webpack-dev-server/commit/927a2b38d4d3a5d8fd50dfce0343634d46fa8a92"><code>927a2b3</code></a> <code>fix(Server): correct <code>node</code> version checks (#1543)</code></li>
<li><a href="https://urls.greenkeeper.io/webpack/webpack-dev-server/commit/fa96a76e9e5507bbf874044be0d95872768abf5e"><code>fa96a76</code></a> <code>chore(PULL_REQUEST_TEMPLATE): allow features (#1539)</code></li>
</ul>
<p>See the <a href="https://urls.greenkeeper.io/webpack/webpack-dev-server/compare/fe3219f614ad84afbaab1ecbd1d9aec4ff337d37...ff2874f5f3a90e5727434cc10f69ac4d54896033">full diff</a></p>
</details>

<details>
  <summary>FAQ and help</summary>

  There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>

---


Your [Greenkeeper](https://greenkeeper.io) bot 🌴
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants