Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reportTime option #1209

Merged
merged 3 commits into from Dec 22, 2017
Merged

feat: reportTime option #1209

merged 3 commits into from Dec 22, 2017

Conversation

@alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Nov 30, 2017

What kind of change does this PR introduce?

feature

Summary
webpack-dev-middleware have option reportTime, but i can't setup this option using webpack-dev-server

Does this PR introduce a breaking change?

No

Other information

No

@alexander-akait alexander-akait force-pushed the feature-report-time branch from f7645f6 to 3fe48bc Nov 30, 2017
@codecov
Copy link

@codecov codecov bot commented Nov 30, 2017

Codecov Report

Merging #1209 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1209   +/-   ##
=======================================
  Coverage   76.31%   76.31%           
=======================================
  Files           5        5           
  Lines         477      477           
  Branches      154      154           
=======================================
  Hits          364      364           
  Misses        113      113

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32c3ceb...4e56847. Read the comment docs.

@shellscape
Copy link
Contributor

@shellscape shellscape commented Dec 5, 2017

@evilebottnawi v3 is leveraging loglevel https://github.com/webpack/webpack-dev-server/blob/next/lib/log.js, and output from that should follow the same option, otherwise we'll get unbalanced expectations for log output. that means we need to update webpack-dev-middleware (which I am planning on doing soon) to use the same patterns. going that route, we should introduce the ability for users to provide their own log prefix, rather than granular options.

shellscape added 2 commits Dec 22, 2017
@shellscape
Copy link
Contributor

@shellscape shellscape commented Dec 22, 2017

@evilebottnawi We can merge this as 2.x of WDS is still using 1.x of WDM and 1.x has this older option.

Note: v2 of webpack-dev-middleware was released and removed reportTime in favor of logTime. v3 of webpack-dev-server supports the same option.

@shellscape shellscape merged commit a168b81 into master Dec 22, 2017
5 checks passed
5 checks passed
Codacy/PR Quality Review Good work! A positive pull request.
Details
codecov/patch Coverage not affected when comparing 32c3ceb...4e56847
Details
codecov/project 76.31% remains the same compared to 32c3ceb
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@alexander-akait alexander-akait deleted the feature-report-time branch Dec 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants