fix: pin strip-ansi to 3.x for ES5 compat #1273
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1273 +/- ##
=======================================
Coverage 75.72% 75.72%
=======================================
Files 5 5
Lines 482 482
Branches 156 156
=======================================
Hits 365 365
Misses 117 117Continue to review full report at Codecov.
|
|
Are you planning on merging and releasing this ASAP? I am also impacted by the same identical issue at the moment. |
|
@julianxhokaxhiu FYI, i've released drop-in-replacement |
|
Thanks, I'll use that temporary until this gets merged :) |
Hopefully it won't! ;) publishing |
|
I tested your drop-in replacement and I still get the same error:
it seems that the ansi-module is not transpiled from arrow functions. //EDIT: See also vercel/next.js#2747 The solution there was to downgrade So this PR is really needed. |
|
@julianxhokaxhiu replied here: #1279 (comment) |
|
@graingert FYI #1279 does not fix CLI --inline usage because injected entries will be processed with user config. |
Enabled serving on IE11 meanwhile webpack/webpack-dev-server#1273 gets merged
|
@yyx990803 I think this looks fine. |
|
Would someone like to submit an issue so that we can upgrade in the future but not break IE? Pinning versions is a sort of a bandaid IMO. |
|
Nevermind, I got it tracked in issues #1286 |
|
I've got limited time today to publish this, however I will see if I can get @SpaceK33z or @sokra to run a release for me on this. |
Follow up for #1270 (comment)
strip-ansiwhich is required by the clients, uses ES6 syntax. Pinning it to 3.x keeps ES5 compat. (The only difference between 3.x and 4.0 is the syntax change)