From c26add234ea95d7cbc81b313de8baad68880fc69 Mon Sep 17 00:00:00 2001 From: Ryan Clark Date: Sat, 17 Feb 2018 00:26:10 +0000 Subject: [PATCH 1/2] fix(addDevServerEntrypoints): allow no entry point to be given --- lib/util/addDevServerEntrypoints.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/util/addDevServerEntrypoints.js b/lib/util/addDevServerEntrypoints.js index d3d95b3a32..8007049008 100644 --- a/lib/util/addDevServerEntrypoints.js +++ b/lib/util/addDevServerEntrypoints.js @@ -27,7 +27,7 @@ module.exports = function addDevServerEntrypoints(webpackOptions, devServerOptio } else if (typeof wpOpt.entry === 'function') { wpOpt.entry = wpOpt.entry(devClient); } else { - wpOpt.entry = devClient.concat(wpOpt.entry); + wpOpt.entry = devClient.concat(wpOpt.entry || './src'); } }); } From c99553ab5fd0dfb39178a3656d87c2924d12f30c Mon Sep 17 00:00:00 2001 From: Ryan Clark Date: Sat, 17 Feb 2018 00:41:35 +0000 Subject: [PATCH 2/2] test(entry): ensure src is added as default if no entry specified --- test/Entry.test.js | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) create mode 100644 test/Entry.test.js diff --git a/test/Entry.test.js b/test/Entry.test.js new file mode 100644 index 0000000000..1ccb2ae6e9 --- /dev/null +++ b/test/Entry.test.js @@ -0,0 +1,18 @@ +'use strict'; + +const assert = require('assert'); +const addDevServerEntrypoints = require('../lib/util/addDevServerEntrypoints'); + +describe('Entry', () => { + it('default to src if no entry point is given', (done) => { + const webpackOptions = {}; + const devServerOptions = {}; + + addDevServerEntrypoints(webpackOptions, devServerOptions); + + assert(webpackOptions.entry.length, 2); + assert(webpackOptions.entry[1], './src'); + + done(); + }); +});