/ webpack-dev-server Public
Fix issue #1316 #1317
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
For Bugs and Features; did you add new tests?
I did not. I absolutely want to, but it appears that the
client-src/default/index.jsfile has no tests at the moment. Or if it does, I couldn't find them in the
I would really love some help and/or guidance on how best to test this code.
Motivation / Use-Case
See #1316 for the bug this addresses.
There's a possibility that this could cause unnecessary reloads in other situations. I don't think it will, but I'm not 100% sure it won't, especially since this bit of code doesn't seem to have any tests right now.