/ webpack-dev-server Public
Fix support for DynamicEntryPlugin #1319
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
For Bugs and Features; did you add new tests?
Yes. I have added tests for this change and I have added new tests for prior behavior to prove that this doesn't break anything.
Motivation / Use-Case
The support for DynamicEntryPlugin added in #802 was incorrect. This fixes
addDevServerEntrypoints.jsas it applies to dynamic endpoints (functions which return an entry object and functions which return a Promise)
This pull request targets the
webpack-4v3.x branch, but I would like to port this back to
2.xas well if you plan to make any more releases under that major version. The only conflict would be the default entry point added in #1310. I could simply exclude that behavior from this change and open up a separate PR targeting the master branch.