Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
speed up incremental builds by not doing excessive stats.toJSON work #1362
For Bugs and Features; did you add new tests?
There's no need to add tests, as it is just a configuration change to toJSON
Motivation / Use-Case
The stats.toJSON call is done every time an incremental build finishes. Given a sufficiently large codebase, this is very SLOW (my repo went from ~30s to ~10s just by getting rid of this)
@@ Coverage Diff @@ ## master #1362 +/- ## ======================================= Coverage 79.14% 79.14% ======================================= Files 6 6 Lines 494 494 Branches 160 160 ======================================= Hits 391 391 Misses 103 103
@shellscape would you mind taking this change? Not everyone in the world can afford to move to the next new thing. I think this little bit of maintenance mode change would benefit quite a LOT of people who still must stick with patch / minor changes.
@kenotron I don't think you understand - I am not a maintainer of this repo, hence I cannot make these changes. I was only asked for my opinion on the change. I'll be unsubscribing from this thread now, as I don't care for it when users levy unfair accusations at me.