Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils/createLogger): ensure quiet always takes precedence (options.quiet) #1486

Merged
merged 1 commit into from Sep 3, 2018

Conversation

lukeed
Copy link
Contributor

@lukeed lukeed commented Sep 2, 2018

  • This is a bugfix
  • This is a code refactor
  • This is a test update
  • This is a typo fix
  • This is a metadata update

For Bugs and Features; did you add new tests?

Doesn't look like logLevel is currently tested, aside from validation. Also not sure how to test this~

Motivation / Use-Case

Setting noInfo and quiet to true still reported errors (and warnings), despite the fact that quiet should silence everything.

Breaking Changes

N/A

Additional Info

Screenshot includes wdm error message. Also displaying the full devServer config above it.

screen shot 2018-09-02 at 12 43 38 pm

@jsf-clabot
Copy link

@jsf-clabot jsf-clabot commented Sep 2, 2018

CLA assistant check
All committers have signed the CLA.

@michael-ciniawsky michael-ciniawsky changed the title Fix: Ensure quiet is respected fix(utils/createLogger): ensure quiet always takes precedence (options.quiet) Sep 2, 2018
@codecov
Copy link

@codecov codecov bot commented Sep 2, 2018

Codecov Report

Merging #1486 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1486   +/-   ##
=======================================
  Coverage   74.02%   74.02%           
=======================================
  Files          10       10           
  Lines         666      666           
=======================================
  Hits          493      493           
  Misses        173      173
Impacted Files Coverage Δ
lib/utils/createLogger.js 87.5% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 065978f...94d1ff4. Read the comment docs.

@alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Sep 3, 2018

@michael-ciniawsky looks like breaking change 😕

@michael-ciniawsky
Copy link
Member

@michael-ciniawsky michael-ciniawsky commented Sep 3, 2018

Strictly speaking yes, but it shouldn't 'break' anything in this case imho

@alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Sep 3, 2018

@michael-ciniawsky feel free to merge and release patch version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants