Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(options): add writeToDisk option to schema #1520

Merged
merged 1 commit into from Oct 10, 2018
Merged

fix(options): add writeToDisk option to schema #1520

merged 1 commit into from Oct 10, 2018

Conversation

oNaiPs
Copy link
Contributor

@oNaiPs oNaiPs commented Oct 8, 2018

According to https://github.com/webpack/webpack-dev-middleware#watchoptions

  • This is a feature
  • This is a bugfix
  • This is a code refactor
  • This is a test update
  • This is a typo fix
  • This is a metadata update

For Bugs and Features; did you add new tests?

Yes

Motivation / Use-Case

Closes #1357

Breaking Changes

None

@jsf-clabot
Copy link

jsf-clabot commented Oct 8, 2018

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Oct 8, 2018

Codecov Report

Merging #1520 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1520   +/-   ##
=======================================
  Coverage   74.02%   74.02%           
=======================================
  Files          10       10           
  Lines         666      666           
=======================================
  Hits          493      493           
  Misses        173      173

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb484ad...6b81fb7. Read the comment docs.

Copy link
Member

@michael-ciniawsky michael-ciniawsky left a comment

@oNaiPs Thx in advance

lib/options.json Outdated Show resolved Hide resolved
@michael-ciniawsky michael-ciniawsky changed the title Add writeToDisk option to schema fix(options): add writeToDisk option to schema Oct 8, 2018
@michael-ciniawsky michael-ciniawsky added this to the 3.1.9 milestone Oct 8, 2018
Copy link
Member

@alexander-akait alexander-akait left a comment

Looks good, just fix above note

@oNaiPs
Copy link
Contributor Author

oNaiPs commented Oct 10, 2018

@michael-ciniawsky @evilebottnawi should be good to go

Copy link
Member

@michael-ciniawsky michael-ciniawsky left a comment

@oNaiPs Thx

@michael-ciniawsky
Copy link
Member

michael-ciniawsky commented Oct 23, 2018

Released in v3.1.10 🎉

This was referenced Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow writeToDisk as a middleware option
4 participants