Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(travis): Node 11 (on OS X) crashes, use 10 for now #1588

Merged
merged 1 commit into from Dec 4, 2018

Conversation

odinho
Copy link
Contributor

@odinho odinho commented Dec 4, 2018

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

No, this is about the tests.

Motivation / Use-Case

Mac OS X (on Travis) has a unknown segfault running the tests. About a month ago the node/stable went from Node 10 to Node 11, and then the project started getting these segfaults on Proxy tests as far as I can see.

Additional Info

This is just a workaround, but the tests failing like now isn't very useful. I've added a bug with Node:
nodejs/node#24835

This change should be reverted once it is fixed.

@odinho
Copy link
Contributor Author

@odinho odinho commented Dec 4, 2018

If it is successful, I can add a comment with a link to this, so it's easy to remember removing it.

@@ -18,7 +18,7 @@ jobs:
stage: Test (MacOS)
os: 'osx'
env: SCRIPT=test
node_js: 'stable'
node_js: 10
Copy link
Member

@alexander-akait alexander-akait Dec 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add comment here on issue 👍

Copy link
Contributor Author

@odinho odinho Dec 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it was a good idea I saw it a bit late :) But I also don't have the URL before actually creating the PR, so :D Will update once the test-run is done.

@odinho
Copy link
Contributor Author

@odinho odinho commented Dec 4, 2018

Very interesting. It hung itself right before the test that segfaults on 11. So there's something fishy on 10 as well. :/

@odinho odinho force-pushed the odinho/use_node_10_on_osx branch from ccee61c to 209cd62 Compare Dec 4, 2018
@codecov
Copy link

@codecov codecov bot commented Dec 4, 2018

Codecov Report

Merging #1588 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1588   +/-   ##
=======================================
  Coverage   74.02%   74.02%           
=======================================
  Files          10       10           
  Lines         670      670           
=======================================
  Hits          496      496           
  Misses        174      174

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55398b5...209cd62. Read the comment docs.

@alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Dec 4, 2018

Looks tests passed

@odinho
Copy link
Contributor Author

@odinho odinho commented Dec 4, 2018

Yes, but the first try did fail (before the comment added). So there is a chance that this will be flaky.

It went from 100% fail, to something less than that, hopefully a very low fail-%, but we only have two data points. :)

@alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Dec 4, 2018

@odinho hm, maybe random failure, sometimes it is happens, let's merge this PR as is, if problem appear again we investigate deeply, big thanks!

@odinho Just question: do you want join to webpack as contributor webpack-dev-server? We don't have enough developers and some PRs stalled due i don't have time on all repos (right now i am one active contributor/issue resolver/etc here).

@alexander-akait alexander-akait merged commit 1fe82de into webpack:master Dec 4, 2018
5 checks passed
@odinho
Copy link
Contributor Author

@odinho odinho commented Dec 4, 2018

@odinho hm, maybe random failure, sometimes it is happens, let's merge this PR as is, if problem appear again we investigate deeply, big thanks!

Great, let's see :)

@odinho Just question: do you want join to webpack as contributor webpack-dev-server? We don't have enough developers and some PRs stalled due i don't have time on all repos (right now i am one active contributor/issue resolver/etc here).

I can't take that on I'm afraid. I'm amazed at all the work you guys are doing, and you being lone maintainer for this one is quite impressive and sad.

I will have a look at some of the other PRs next week and see why they are stalled and if there's some ways I can help without being a member. :)

@odinho odinho deleted the odinho/use_node_10_on_osx branch Dec 4, 2018
@alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Dec 5, 2018

@odinho thanks, just help with issues and PRs (answer, review, mark as duplicate/invalid and etc). Any help welcome 👍

@hiroppy hiroppy mentioned this pull request Feb 8, 2019
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants