Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scriptHost fix #2246

Merged
merged 3 commits into from Sep 16, 2019
Merged

scriptHost fix #2246

merged 3 commits into from Sep 16, 2019

Conversation

knagaitsev
Copy link
Collaborator

@knagaitsev knagaitsev commented Sep 12, 2019

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Yes

Motivation / Use-Case

Pulled in changes from here and updated the test snapshot to fix CI: #2229

Breaking Changes

N/A

Additional Info

misak113 and others added 2 commits Sep 12, 2019
* for example when html-webpack-inline-source-plugin is used, the JS is inlined in HTML in script tag. So in this case document.currentScript.getAttribute('src') is undefined
* undefined cannot be used as string with method replace. This cause a fatal error and crash app
@codecov
Copy link

codecov bot commented Sep 12, 2019

Codecov Report

Merging #2246 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2246      +/-   ##
=========================================
+ Coverage    93.9%   93.9%   +<.01%     
=========================================
  Files          34      34              
  Lines        1279    1280       +1     
  Branches      367     368       +1     
=========================================
+ Hits         1201    1202       +1     
  Misses         71      71              
  Partials        7       7
Impacted Files Coverage Δ
client-src/default/utils/createSocketUrl.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e2224e...28b63a8. Read the comment docs.

@alexander-akait
Copy link
Member

alexander-akait commented Sep 13, 2019

@Loonride Can we add tests?

@knagaitsev
Copy link
Collaborator Author

knagaitsev commented Sep 13, 2019

@evilebottnawi undefined is the new test case in createSocketUrl.test.js. That is the only problem this addresses it seems based on #2229

@alexander-akait alexander-akait merged commit 00903f6 into webpack:master Sep 16, 2019
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants