Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put webpack-cli serve flags in dev server #2270

Merged
merged 1 commit into from Oct 4, 2019

Conversation

knagaitsev
Copy link
Collaborator

@knagaitsev knagaitsev commented Oct 2, 2019

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

N/A

Motivation / Use-Case

Flags for webpack-cli serve need to be present on webpack-dev-server to be maintained. It is better if they are on master so that they can be part of a release, then webpack-cli next can access them easily.

The flags here may not be perfectly up-to-date, I will bring them up to date before merge.

Breaking Changes

None

Additional Info

@codecov
Copy link

codecov bot commented Oct 2, 2019

Codecov Report

Merging #2270 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2270   +/-   ##
======================================
  Coverage    93.9%   93.9%           
======================================
  Files          34      34           
  Lines        1280    1280           
  Branches      365     368    +3     
======================================
  Hits         1202    1202           
  Misses         71      71           
  Partials        7       7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9108d5b...8db157a. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Good job!

hiroppy
hiroppy approved these changes Oct 4, 2019
@hiroppy hiroppy merged commit 98aa8e1 into webpack:master Oct 4, 2019
17 checks passed
digitaljohn pushed a commit to signal-noise/webpack-dev-server that referenced this issue Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants