Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update package-lock.json #2289

Merged
merged 1 commit into from Oct 22, 2019
Merged

Conversation

hiroppy
Copy link
Member

@hiroppy hiroppy commented Oct 22, 2019

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

no

Motivation / Use-Case

                                                                                
                       === npm audit security report ===                        
                                                                                
# Run  npm update https-proxy-agent --depth 2  to resolve 1 vulnerability
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ High          │ Machine-In-The-Middle                                        │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ https-proxy-agent                                            │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ puppeteer [dev]                                              │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ puppeteer > https-proxy-agent                                │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://npmjs.com/advisories/1184                            │
└───────────────┴──────────────────────────────────────────────────────────────┘

Breaking Changes

Additional Info

@codecov
Copy link

codecov bot commented Oct 22, 2019

Codecov Report

Merging #2289 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2289   +/-   ##
=======================================
  Coverage   93.92%   93.92%           
=======================================
  Files          34       34           
  Lines        1284     1284           
  Branches      366      369    +3     
=======================================
  Hits         1206     1206           
+ Misses         77       71    -6     
- Partials        1        7    +6
Impacted Files Coverage Δ
client-src/clients/WebsocketClient.js 57.89% <0%> (ø) ⬆️
client-src/clients/SockJSClient.js 61.53% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1d4d7f...8e7e83a. Read the comment docs.

@hiroppy hiroppy merged commit 4abc8c3 into master Oct 22, 2019
3 checks passed
@hiroppy hiroppy deleted the feature/update-package-lock branch Oct 22, 2019
digitaljohn pushed a commit to signal-noise/webpack-dev-server that referenced this pull request Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants