Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add @types/serve-static to dependencies #4468



Copy link

@wegry wegry commented May 31, 2022

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

This change should be covered by the lint-types npm script.

Motivation / Use-Case

Fix #4467 with Yarn PnP and Typescript.

Breaking Changes

Additional Info

Copy link

linux-foundation-easycla bot commented May 31, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • login: wegry / name: Zach Wegrzyniak (3f0fe64)

alexander-akait previously approved these changes May 31, 2022
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #4468 (487a325) into master (07aaa45) will decrease coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4468      +/-   ##
- Coverage   92.31%   92.19%   -0.13%     
  Files          16       16              
  Lines        1601     1601              
  Branches      604      604              
- Hits         1478     1476       -2     
- Misses        112      114       +2     
  Partials       11       11              
Impacted Files Coverage Δ
lib/servers/WebsocketServer.js 89.74% <0.00%> (-5.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07aaa45...487a325. Read the comment docs.

Copy link
Contributor Author

wegry commented May 31, 2022

I tweaked the commit message to try and match standard changelog.

@snitin315 snitin315 changed the title Add @types/serve-static to dependencies #4467 fix: add @types/serve-static to dependencies Jun 6, 2022
Copy link

@alexander-akait alexander-akait left a comment

We should do patch release, pinned, will merge after CI

@alexander-akait alexander-akait merged commit af83deb into webpack:master Jun 6, 2022
14 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
3 participants