New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebuild hyperlink #2382
Rebuild hyperlink #2382
Changes from all commits
b6fedfa
d0f9ed5
b70a775
958c136
fa437ea
63ae0bd
00e8fbc
a317676
12dccb7
de51fb0
42b9d84
adcd3bd
422e7fa
f400cd2
1c3ee46
fc4e876
b363414
bd227a8
ade9cb7
1a19c2d
071407e
73dec22
73779f7
43967dd
a8c6872
076dd73
2ef4cb9
4932f17
3ddaa42
2438e5b
710188c
972de53
ebede53
9e8fab8
42cb344
cabd893
5321534
7b20e07
21c589f
ab6f6c1
e48c836
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,3 +8,4 @@ src/**/_*.md | |
npm-debug.log | ||
yarn-error.log | ||
package-lock.json | ||
.cache |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,52 @@ | ||
branches: | ||
only: | ||
- master | ||
- develop | ||
sudo: false | ||
language: node_js | ||
node_js: | ||
- "8" | ||
sudo: required | ||
install: | ||
- yarn | ||
- sudo pip install proselint | ||
before_script: | ||
- source ./src/scripts/env.sh | ||
script: | ||
- bash ./src/scripts/deploy.sh | ||
|
||
cache: | ||
yarn: true | ||
directories: | ||
- node_modules | ||
- dist | ||
- .cache | ||
|
||
stages: | ||
- Build | ||
- Post-build | ||
|
||
jobs: | ||
fast_finish: true | ||
allow_failures: | ||
- name: External Link Check | ||
|
||
include: | ||
- stage: Build | ||
name: Lint and Build | ||
before_install: npm install --global yarn | ||
install: yarn | ||
script: | ||
- yarn lint:js | ||
- yarn lint:markdown | ||
- yarn lint:social | ||
- yarn build | ||
- yarn lint:links | ||
|
||
- stage: Build | ||
name: Proselint | ||
language: python | ||
python: 3.6 | ||
cache: | ||
pip: true | ||
directories: | ||
- $HOME/.cache | ||
install: pip install -r requirements.txt | ||
script: cp .proselintrc ~/ && proselint src/content | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this really running before build? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Proselint is running in parallel with the remaining linting and the build. This is because it tends to be a slow run, but a really fast container boot because it only relies on the python ecosystem. Proselint and the remaining limiting plus build run in parallel. If any of them fails it fails the pipeline, so you'll have the same effect as before, but faster once you remove the parallelization limitation |
||
|
||
- stage: Post-build | ||
name: Deploy | ||
if: branch = master | ||
script: bash ./src/scripts/deploy.sh | ||
|
||
- stage: Post-build | ||
name: External Link Check | ||
script: yarn linkcheck |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -26,17 +26,24 @@ | |
"scripts": { | ||
"clean": "rimraf ./dist src/content/**/_*.md src/**/_*.json", | ||
"start": "cross-env NODE_ENV=development webpack-dev-server --config webpack.dev.js --env.dev", | ||
"update-repos": "node src/utilities/fetch-package-repos.js", | ||
"content": "node src/scripts/build-content-tree.js ./src/content ./src/_content.json", | ||
"build-test": "npm run build && http-server build/", | ||
"fetch": "sh src/scripts/fetch.sh", | ||
"fetch": "run-p fetch:*", | ||
"fetch:readmes": "node src/utilities/fetch-package-readmes.js", | ||
"fetch:supporters": "node src/utilities/fetch-supporters.js", | ||
"fetch:starter-kits": "node src/utilities/fetch-starter-kits.js", | ||
"prebuild": "npm run clean", | ||
"build": "npm run fetch && npm run content && cross-env NODE_ENV=production webpack --config webpack.prod.js && npm run sitemap && echo webpack.js.org > dist/CNAME", | ||
"build": "run-s fetch content && cross-env NODE_ENV=production webpack --config webpack.prod.js", | ||
"postbuild": "npm run sitemap", | ||
"test": "npm run lint", | ||
"lint": "run-s lint:*", | ||
"lint:js": "eslint src --ext .js,.jsx,.md", | ||
"lint:js": "eslint src --ext .js,.jsx,.md --cache true --cache-location .cache/.eslintcache", | ||
"lint:markdown": "markdownlint --config ./.markdownlint.json *.md ./src/content/**/*.md --ignore './src/content/**/_*.md'", | ||
"lint:social": "alex . -q", | ||
"lint:prose": "cp .proselintrc ~/ && proselint src/content", | ||
"lint:links": "hyperlink -r dist/index.html --canonicalroot https://webpack.js.org/ -i | tee internal-links.tap | tap-spot", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What is There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Tee writes a copy of stdout to a file while paying through the stdout pipe. It let's us keep a copy of the raw tap output while seeing the nice formatted report in the console. It's just in case we need to go back and look at the output in a different manner, for example if the reporter has a bug, or we forgot to copy/paste the console output There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It is a dependency or something available in linux? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh yeah, linux program, cool! TIL |
||
"linkcheck": "hyperlink -r dist/index.html --canonicalroot https://webpack.js.org/ --skip support__ --skip sidecar.gitter.im --skip vimdoc.sourceforge.net --skip img.shields.io --skip npmjs.com/package/ --skip opencollective.com/webpack --todo external-redirect | tee external-links.tap | tap-spot", | ||
"sitemap": "cd dist && sitemap-static --prefix=https://webpack.js.org/ > sitemap.xml", | ||
"serve": "npm run build && sirv start ./dist --port 4000", | ||
"deploy": "gh-pages -d dist" | ||
|
@@ -47,11 +54,15 @@ | |
} | ||
}, | ||
"lint-staged": { | ||
"*.{js,jsx,md}": ["npm run lint:js"], | ||
"*.md": ["npm run lint:markdown"] | ||
"*.{js,jsx,md}": [ | ||
"npm run lint:js" | ||
], | ||
"*.md": [ | ||
"npm run lint:markdown" | ||
] | ||
}, | ||
"devDependencies": { | ||
"@octokit/rest": "^15.2.6", | ||
"@octokit/rest": "^15.9.4", | ||
"alex": "^5.1.0", | ||
"autoprefixer": "^7.2.3", | ||
"babel-core": "^6.26.0", | ||
|
@@ -62,7 +73,7 @@ | |
"babel-plugin-transform-object-rest-spread": "^6.26.0", | ||
"babel-preset-env": "^1.6.0", | ||
"babel-preset-react": "^6.24.1", | ||
"copy-webpack-plugin": "^4.3.0", | ||
"copy-webpack-plugin": "4.5.2", | ||
"cross-env": "5.2.0", | ||
"css-loader": "^0.28.5", | ||
"directory-tree": "2.1.0", | ||
|
@@ -81,7 +92,7 @@ | |
"html-webpack-template": "^6.1.0", | ||
"http-server": "^0.10.0", | ||
"husky": "^1.0.0-rc.8", | ||
"hyperlink": "^3.0.1", | ||
"hyperlink": "^4.0.0", | ||
"lint-staged": "^7.2.0", | ||
"loader-utils": "^1.1.0", | ||
"lodash": "^4.17.4", | ||
|
@@ -113,7 +124,7 @@ | |
"sitemap-static": "^0.4.2", | ||
"static-site-generator-webpack-plugin": "^3.4.1", | ||
"style-loader": "^0.18.2", | ||
"tap-parser": "^6.0.1", | ||
"tap-spot": "^1.1.1", | ||
"through2": "^2.0.3", | ||
"uglifyjs-webpack-plugin": "^1.1.6", | ||
"webpack": "^3.10.0", | ||
|
@@ -122,9 +133,9 @@ | |
}, | ||
"dependencies": { | ||
"@rigor789/remark-autolink-headings": "^5.1.0", | ||
"ajv": "^5.5.2", | ||
"docsearch.js": "^2.5.2", | ||
"gitter-sidecar": "^1.2.3", | ||
"ajv": "^5.5.2", | ||
"javascriptstuff-db": "^1.12.0", | ||
"lodash.throttle": "^4.1.1", | ||
"prop-types": "^15.5.10", | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
# Webpack documentation repositories | ||
|
||
The files in this directory are auto generated from `src/utils/fetch-package-repos.js` and should not be edited by hand. Any manual changes will be overwritten by the automation next time it runs. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
[ | ||
"webpack-contrib/json-loader", | ||
"webpack-contrib/raw-loader", | ||
"webpack-contrib/coffee-loader", | ||
"webpack-contrib/css-loader", | ||
"webpack-contrib/style-loader", | ||
"webpack-contrib/script-loader", | ||
"webpack-contrib/less-loader", | ||
"webpack-contrib/bundle-loader", | ||
"webpack-contrib/val-loader", | ||
"webpack-contrib/file-loader", | ||
"webpack-contrib/url-loader", | ||
"webpack-contrib/i18n-loader", | ||
"webpack-contrib/json5-loader", | ||
"webpack-contrib/worker-loader", | ||
"webpack-contrib/jshint-loader", | ||
"webpack-contrib/imports-loader", | ||
"webpack-contrib/exports-loader", | ||
"webpack-contrib/mocha-loader", | ||
"webpack-contrib/coverjs-loader", | ||
"webpack-contrib/expose-loader", | ||
"webpack-contrib/node-loader", | ||
"webpack-contrib/coffee-redux-loader", | ||
"webpack-contrib/transform-loader", | ||
"webpack-contrib/html-loader", | ||
"webpack-contrib/sass-loader", | ||
"webpack-contrib/source-map-loader", | ||
"webpack-contrib/react-proxy-loader", | ||
"webpack-contrib/null-loader", | ||
"webpack-contrib/multi-loader", | ||
"webpack-contrib/istanbul-instrumenter-loader", | ||
"webpack-contrib/eslint-loader", | ||
"webpack-contrib/yaml-frontmatter-loader", | ||
"webpack-contrib/svg-inline-loader", | ||
"webpack-contrib/restyle-loader", | ||
"webpack-contrib/gzip-loader", | ||
"webpack-contrib/cache-loader", | ||
"webpack-contrib/thread-loader", | ||
"webpack-contrib/polymer-webpack-loader", | ||
"webpack-contrib/workerize-loader", | ||
"webpack-contrib/config-loader", | ||
"babel/babel-loader", | ||
"postcss/postcss-loader", | ||
"peerigon/extract-loader" | ||
] |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
[ | ||
"webpack-contrib/i18n-webpack-plugin", | ||
"webpack-contrib/component-webpack-plugin", | ||
"webpack-contrib/compression-webpack-plugin", | ||
"webpack-contrib/extract-text-webpack-plugin", | ||
"webpack-contrib/copy-webpack-plugin", | ||
"webpack-contrib/npm-install-webpack-plugin", | ||
"webpack-contrib/stylelint-webpack-plugin", | ||
"webpack-contrib/babel-minify-webpack-plugin", | ||
"webpack-contrib/uglifyjs-webpack-plugin", | ||
"webpack-contrib/zopfli-webpack-plugin", | ||
"webpack-contrib/closure-webpack-plugin", | ||
"webpack-contrib/css-webpack-plugin", | ||
"webpack-contrib/mini-css-extract-plugin" | ||
] |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
proselint |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
webpack.js.org |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,6 +3,10 @@ | |
|
||
.organization { | ||
padding: 1.5em; | ||
|
||
&__title > h4 { | ||
margin-top: 0; // Overrides markdown scss | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why add There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Seems all the basic styles are now scoped under I'm not happy with this solution, but I'm not going to redo the CSS architecture as well when my focus is fixing broken links There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Me neither, will fix :) |
||
} | ||
} | ||
|
||
.organization__projects { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yarn lint:links
is failing too https://travis-ci.org/webpack/webpack.js.org/jobs/411353517There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Random badge timeout. They seem to happen a lot. Might want to mark those as optional with a --todo