Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(config) target updates to current webpack state #2597

Merged
merged 1 commit into from Oct 22, 2018

Conversation

EugeneHlushko
Copy link
Member

  • atom and electron no longer allowed via schema
  • outdated link and example

@montogeek
Copy link
Member

When was this changed in webpack?

@EugeneHlushko
Copy link
Member Author

https://github.com/webpack/webpack/blob/master/schemas/WebpackOptions.json#L2113
I dont have chance to check when @montogeek maybe tomorrow i can do git annotate and tell more if thats important

@EugeneHlushko
Copy link
Member Author

@montogeek confirmed with Tobias, this is good to go.

"sokra [11:19 AM]
Only stuff in the schema is usable and part of the public API. Can be removed from the docs. You can also remove them from the code if you want to. Or create an issue."

@montogeek montogeek merged commit a55476e into master Oct 22, 2018
@montogeek
Copy link
Member

Thanks!

@montogeek montogeek deleted the docs/config-target branch October 22, 2018 15:00
@EugeneHlushko
Copy link
Member Author

dat was quick, ty!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants