Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd rel="noopener nofollow" for links to sponsor websites #2688
+1
−0
Conversation
joealcorn
added some commits
Dec 2, 2018
EugeneHlushko
added
the
Infrastructure
label
Dec 3, 2018
montogeek
merged commit 38e6e57
into
webpack:master
Dec 3, 2018
This comment has been minimized.
This comment has been minimized.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
joealcorn commentedDec 3, 2018
•
edited
Hello👋
When linking to external sites with
target='_blank', it's important to addrel='noopener'as a security measure. Otherwise the external site is able to navigate the original browser tab in the background, for example to a phishing site.More info here: https://mathiasbynens.github.io/rel-noopener/
You've also got a bit of a spam problem at the moment - there are lots of $2 donations that seem to exist solely to build backlinks for spammy gambling websites.That seems to have been mostly taken care of in #2681. However, I've also added
rel='nofollow', which should let search engines know it's an untrusted link and hopefully protect your own search ranking. Hopefully that takes away some of the incentive to spam. I wrote about the spam a bit here: https://joealcorn.co.uk/blog/2018/donations-as-a-vector-for-spam