From cab53a7455629b31d7649a6ae8bca1091bda3528 Mon Sep 17 00:00:00 2001 From: furkle Date: Thu, 9 May 2019 12:55:18 -0400 Subject: [PATCH 1/5] Fix URL error in src/content/concepts/loaders.mdx This fixes the broken link (pointing to https://webpack.js.org/development/how-to-write-a-loader) and points it to the correct URL (https://webpack.js.org/contribute/writing-a-loader/). --- src/content/concepts/loaders.mdx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/content/concepts/loaders.mdx b/src/content/concepts/loaders.mdx index d5b6d90fd3e2..639564db76fa 100644 --- a/src/content/concepts/loaders.mdx +++ b/src/content/concepts/loaders.mdx @@ -148,4 +148,4 @@ functions (loaders). Users now have more flexibility to include fine-grained log Loaders follow the standard [module resolution](/concepts/module-resolution/). In most cases it will be loaded from the [module path](/concepts/module-resolution/#module-paths) (think `npm install`, `node_modules`). -A loader module is expected to export a function and be written in Node.js compatible JavaScript. They are most commonly managed with npm, but you can also have custom loaders as files within your application. By convention, loaders are usually named `xxx-loader` (e.g. `json-loader`). See ["How to Write a Loader?"](/development/how-to-write-a-loader) for more information. +A loader module is expected to export a function and be written in Node.js compatible JavaScript. They are most commonly managed with npm, but you can also have custom loaders as files within your application. By convention, loaders are usually named `xxx-loader` (e.g. `json-loader`). See ["How to Write a Loader?"](/contribute/how-to-write-a-loader) for more information. From f4940d37ea70298e32aeafb479fee985a607ef2e Mon Sep 17 00:00:00 2001 From: furkle Date: Thu, 9 May 2019 13:01:47 -0400 Subject: [PATCH 2/5] Update loaders.mdx --- src/content/concepts/loaders.mdx | 1 + 1 file changed, 1 insertion(+) diff --git a/src/content/concepts/loaders.mdx b/src/content/concepts/loaders.mdx index 639564db76fa..4fad750eb687 100644 --- a/src/content/concepts/loaders.mdx +++ b/src/content/concepts/loaders.mdx @@ -14,6 +14,7 @@ contributors: - EugeneHlushko - wizardofhogwarts - lukasgeiter + - furkle --- Loaders are transformations that are applied on the source code of a module. They allow you to pre-process files as you `import` or “load” them. Thus, loaders are kind of like “tasks” in other build tools and provide a powerful way to handle front-end build steps. Loaders can transform files from a different language (like TypeScript) to JavaScript or inline images as data URLs. Loaders even allow you to do things like `import` CSS files directly from your JavaScript modules! From 9ecb9673769144ec71815da87adb2288cc1fbb60 Mon Sep 17 00:00:00 2001 From: furkle Date: Thu, 9 May 2019 13:05:14 -0400 Subject: [PATCH 3/5] Update loaders.mdx Fixing typo. --- src/content/concepts/loaders.mdx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/content/concepts/loaders.mdx b/src/content/concepts/loaders.mdx index d5b6d90fd3e2..878a401cb4f8 100644 --- a/src/content/concepts/loaders.mdx +++ b/src/content/concepts/loaders.mdx @@ -148,4 +148,4 @@ functions (loaders). Users now have more flexibility to include fine-grained log Loaders follow the standard [module resolution](/concepts/module-resolution/). In most cases it will be loaded from the [module path](/concepts/module-resolution/#module-paths) (think `npm install`, `node_modules`). -A loader module is expected to export a function and be written in Node.js compatible JavaScript. They are most commonly managed with npm, but you can also have custom loaders as files within your application. By convention, loaders are usually named `xxx-loader` (e.g. `json-loader`). See ["How to Write a Loader?"](/development/how-to-write-a-loader) for more information. +A loader module is expected to export a function and be written in Node.js compatible JavaScript. They are most commonly managed with npm, but you can also have custom loaders as files within your application. By convention, loaders are usually named `xxx-loader` (e.g. `json-loader`). See ["Writing a Loader?"](/development/writing-a-loader) for more information. From c6f5ed67083d556a11f5db763c841a5ec58ff117 Mon Sep 17 00:00:00 2001 From: furkle Date: Thu, 9 May 2019 13:06:00 -0400 Subject: [PATCH 4/5] Update loaders.mdx Fixing typo. --- src/content/concepts/loaders.mdx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/content/concepts/loaders.mdx b/src/content/concepts/loaders.mdx index 4fad750eb687..e07a2584bd0b 100644 --- a/src/content/concepts/loaders.mdx +++ b/src/content/concepts/loaders.mdx @@ -149,4 +149,4 @@ functions (loaders). Users now have more flexibility to include fine-grained log Loaders follow the standard [module resolution](/concepts/module-resolution/). In most cases it will be loaded from the [module path](/concepts/module-resolution/#module-paths) (think `npm install`, `node_modules`). -A loader module is expected to export a function and be written in Node.js compatible JavaScript. They are most commonly managed with npm, but you can also have custom loaders as files within your application. By convention, loaders are usually named `xxx-loader` (e.g. `json-loader`). See ["How to Write a Loader?"](/contribute/how-to-write-a-loader) for more information. +A loader module is expected to export a function and be written in Node.js compatible JavaScript. They are most commonly managed with npm, but you can also have custom loaders as files within your application. By convention, loaders are usually named `xxx-loader` (e.g. `json-loader`). See ["Writing a Loader"](/contribute/writing-a-loader) for more information. From d9828c6aaf0b0b27f9f27838e2b52ced4e45e033 Mon Sep 17 00:00:00 2001 From: furkle Date: Fri, 10 May 2019 14:04:34 -0400 Subject: [PATCH 5/5] Update PULL_REQUEST_TEMPLATE.md Fixing broken link. --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 199e9e7094fb..900eac5b5a8d 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -7,4 +7,4 @@ _describe your changes..._ [1]: https://cla.js.foundation/webpack/webpack.js.org -[2]: https://webpack.js.org/writers-guide/ +[2]: https://webpack.js.org/contribute/writers-guide/