Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed page title of External Configurations #900

Merged
merged 5 commits into from Feb 16, 2017

Conversation

tarang9211
Copy link
Contributor

@tarang9211 tarang9211 commented Feb 16, 2017

@tarang9211
Copy link
Contributor Author

@simon04 Let me know what else has to be changed for this to get working!

Copy link
Collaborator

@simon04 simon04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename the file: external-configs.mdjavascript-alternatives.md

In the antwar section for configuration, specify a redirect from the old page to the new one as it has it has been done here: Add {'external-config': 'javascript-alternatives'}. This should work, but please test beforehand.

@simon04 simon04 changed the title changed page title Changed page title of External Configurations Feb 16, 2017
@tarang9211
Copy link
Contributor Author

@simon04 sounds good. Pushed a commit to handle the stuff you mentioned above, let me know if it looks alright to you.

antwar.config.js Outdated
@@ -89,7 +89,8 @@ module.exports = {
false,
/^\.\/.*\.md$/
);
}
},
redirects: {'external-config': 'javascript-alternatives'}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is syntactically invalid. Change it so that is is analogue to here:

-      },
-      redirects: {'external-config': 'javascript-alternatives'}
+      }, {
+        'external-config': 'javascript-alternatives'
+      }

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, missed that.

antwar.config.js Outdated
@@ -89,6 +89,8 @@ module.exports = {
false,
/^\.\/.*\.md$/
);
}, {
'external-config': 'javascript-alternatives'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must be called external-configs (with a trailing s) conforming with the former filename. Sorry for my typo!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Copy link
Collaborator

@simon04 simon04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@simon04 simon04 merged commit c4bab56 into webpack:master Feb 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants