diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 577688a4a3c..ca2ca49096a 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -161,7 +161,7 @@ jobs: yarn --frozen-lockfile --ignore-engines if: matrix.node-version == '10.x' || matrix.node-version == '12.x' || matrix.node-version == '14.x' - run: | - yarn upgrade eslint-plugin-jest@~28.4.0 eslint-plugin-jsdoc@^47.0.0 husky@^8.0.3 lint-staged@^13.2.1 cspell@^6.31.1 open-cli@^7.2.0 nyc@^15.1.0 @eslint/js@^8 + yarn upgrade eslint-plugin-jest@~28.4.0 eslint-plugin-jsdoc@^47.0.0 husky@^8.0.3 lint-staged@^13.2.1 cspell@^6.31.1 open-cli@^7.2.0 nyc@^15.1.0 eslint@^8 @eslint/js@^8 yarn --frozen-lockfile if: matrix.node-version == '16.x' # Install main version of our deps diff --git a/eslint.config.js b/eslint.config.js index 8d92d4107f8..908f375bada 100644 --- a/eslint.config.js +++ b/eslint.config.js @@ -85,7 +85,6 @@ module.exports = [ ], "jsdoc/check-alignment": "off", "jsdoc/tag-lines": "off", - // TODO enable me "jsdoc/valid-types": "off", // TODO remove me after switch to typescript strict mode "jsdoc/require-jsdoc": "off", diff --git a/lib/serialization/ObjectMiddleware.js b/lib/serialization/ObjectMiddleware.js index 81716919d82..aa9d0f16fa6 100644 --- a/lib/serialization/ObjectMiddleware.js +++ b/lib/serialization/ObjectMiddleware.js @@ -138,7 +138,8 @@ jsTypes.set(TypeError, new ErrorObjectSerializer(TypeError)); // real Object and Array types to. These types may occur in the wild too, e. g. when // using Structured Clone in postMessage. if (exports.constructor !== Object) { - const Obj = /** @type {typeof object} */ (exports.constructor); + // eslint-disable-next-line jsdoc/check-types + const Obj = /** @type {typeof Object} */ (exports.constructor); const Fn = /** @type {typeof Function} */ (Obj.constructor); for (const [type, config] of Array.from(jsTypes)) { if (type) {