From ab7ecb30ee08abd719a7ab4d79bde498cd01e90c Mon Sep 17 00:00:00 2001 From: Tobias Koppers Date: Tue, 26 Jun 2018 15:27:44 +0200 Subject: [PATCH] fixes #7499 --- lib/optimize/ConcatenatedModule.js | 1 + .../missing-module-7499/example/constants.js | 1 + .../side-effects/missing-module-7499/example/index.js | 2 ++ .../missing-module-7499/example/package.json | 3 +++ test/cases/side-effects/missing-module-7499/index.js | 10 ++++++++++ test/cases/side-effects/missing-module-7499/lazy.js | 5 +++++ 6 files changed, 22 insertions(+) create mode 100644 test/cases/side-effects/missing-module-7499/example/constants.js create mode 100644 test/cases/side-effects/missing-module-7499/example/index.js create mode 100644 test/cases/side-effects/missing-module-7499/example/package.json create mode 100644 test/cases/side-effects/missing-module-7499/index.js create mode 100644 test/cases/side-effects/missing-module-7499/lazy.js diff --git a/lib/optimize/ConcatenatedModule.js b/lib/optimize/ConcatenatedModule.js index 2ec0d4bc775..2c44fa028b5 100644 --- a/lib/optimize/ConcatenatedModule.js +++ b/lib/optimize/ConcatenatedModule.js @@ -281,6 +281,7 @@ class ConcatenatedModule extends Module { // Info from Factory this.rootModule = rootModule; + this.factoryMeta = rootModule.factoryMeta; // Info from Compilation this.index = rootModule.index; diff --git a/test/cases/side-effects/missing-module-7499/example/constants.js b/test/cases/side-effects/missing-module-7499/example/constants.js new file mode 100644 index 00000000000..9b857576f70 --- /dev/null +++ b/test/cases/side-effects/missing-module-7499/example/constants.js @@ -0,0 +1 @@ +export const hello = 'world' diff --git a/test/cases/side-effects/missing-module-7499/example/index.js b/test/cases/side-effects/missing-module-7499/example/index.js new file mode 100644 index 00000000000..a06738b7396 --- /dev/null +++ b/test/cases/side-effects/missing-module-7499/example/index.js @@ -0,0 +1,2 @@ +import * as constants from './constants' +export { constants } diff --git a/test/cases/side-effects/missing-module-7499/example/package.json b/test/cases/side-effects/missing-module-7499/example/package.json new file mode 100644 index 00000000000..a43829151e1 --- /dev/null +++ b/test/cases/side-effects/missing-module-7499/example/package.json @@ -0,0 +1,3 @@ +{ + "sideEffects": false +} diff --git a/test/cases/side-effects/missing-module-7499/index.js b/test/cases/side-effects/missing-module-7499/index.js new file mode 100644 index 00000000000..714aabf74b4 --- /dev/null +++ b/test/cases/side-effects/missing-module-7499/index.js @@ -0,0 +1,10 @@ +import './example' + +it("should run correctly", function() { + return import('./lazy').then(lazy => { + expect(lazy.default()).toEqual({ + hello: "world", + [Symbol.toStringTag]: "Module" + }); + }) +}); diff --git a/test/cases/side-effects/missing-module-7499/lazy.js b/test/cases/side-effects/missing-module-7499/lazy.js new file mode 100644 index 00000000000..f916eaa5b10 --- /dev/null +++ b/test/cases/side-effects/missing-module-7499/lazy.js @@ -0,0 +1,5 @@ +import { constants } from './example' + +export default function getConstants() { + return constants; +}