optimization.sideEffects is compatible with cacheUnaffected

webpack · Oct 5, 2021 · da098d7 · da098d7
1 parent 56653f8
commit da098d7
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 9 deletions.
diff --git a/lib/optimize/SideEffectsFlagPlugin.js b/lib/optimize/SideEffectsFlagPlugin.js
@@ -235,12 +235,6 @@ class SideEffectsFlagPlugin {
 						stage: STAGE_DEFAULT
 					},
 					modules => {
-						if (compilation.moduleMemCaches) {
-							throw new Error(
-								"optimization.sideEffects can't be used with cacheUnaffected as side effects optimization is a global effect"
-							);
-						}
-
 						const logger = compilation.getLogger(
 							"webpack.SideEffectsFlagPlugin"
 						);

diff --git a/test/WatchCacheUnaffectedTestCases.longtest.js b/test/WatchCacheUnaffectedTestCases.longtest.js
@@ -4,8 +4,5 @@ describeCases({
 	name: "WatchCacheUnaffectedTestCases",
 	experiments: {
 		cacheUnaffected: true
-	},
-	optimization: {
-		sideEffects: false
 	}
 });