Unable to disable comment preserving in uglifyjs plugin

[dashed]

Trying to do this: new webpack.optimize.UglifyJsPlugin({ comments: false })

Setting will be overwritten because of this:
https://github.com/webpack/webpack/blob/master/lib/optimize/UglifyJsPlugin.js#L79

Other reference:
https://github.com/mishoo/UglifyJS2/blob/master/lib/output.js#L62

[sokra]

Yes that's a bug...
Workaround: new webpack.optimize.UglifyJsPlugin({ output: {comments: false} })

[dashed]

Wow. Thanks for quick reply!

Workaround works.

[drawveloper]

I have the inverse problem. Uglify is removing comments inside an HTML string and "comments":"all" is having no effect. Any idea when I'll be able to configure this properly?

[drawveloper]

Oops, apparently it was the html loader who was realizing there was minification going on and turned it's own minification processes on. I have manually disabled it and everything works.

[tleunen]

Found this post while searching for the same issue.

@sokra gave a workaround, which still works. Does it mean it's the right way now and it's not a bug?
Yep.. still a bug I guess :) https://github.com/webpack/webpack/blob/master/lib/optimize/UglifyJsPlugin.js#L95

[dashed]

@tleunen Should be resolved with #1298.

[WickyNilliams]

I'm still seeing this issue in latest version of webpack. @sokra's workaround does the trick

[NomNomCameron]

Can confirm that @sokra's workaround is still required for this

[sokra]

btw. it's intended that webpack preserves some comments. This is for legal reasons. By default comments with @license, @preserve or starting with /*! are preserved.

[dashed]

@WickyNilliams @NomNomCameron I tested using v1.12.6 on jquery source, and it seems to work just fine (with or without the workaround). The test I provided in my PR (#1298) didn't fail.

Are you sure you're using latest webpack version for both local and global?

[ccorcos]

@sokra intersting! what legal reasons?

[dashed]

@ccorcos you typically want to preserve licenses which are usually at the top as a multi-line comment.

[ccorcos]

That's what I'm reading here, but why is that?

[dashed]

@ccorcos some licenses require it.

[ccorcos]

Look at this mess:

!function(e){function t(n){if(r[n])return r[n].exports;var o=r[n]={i:n,l:!1,exports:{}};return e[n].call(o.exports,o,o.exports,t),o.l
  !*** ./~/lodash/lodash.js ***!
  \****************************/
function(e,t,n){(function(e,r){var o;(function(){function i(e,t){return e.set(t[0],t[1]),e}function a(e,t){return e.add(t),e}function
  !*** ./src/client/environment.ts ***!
  \***********************************/
function(e,t,n){"use strict";Object.defineProperty(t,"__esModule",{value:!0}),t.default=null},/*!************************************
  !*** ./src/client/components/Component.ts ***!
  \********************************************/
function(e,t,n){"use strict";var r=this&&this.__extends||function(){var e=Object.setPrototypeOf||{__proto__:[]}instanceof Array&&func
  !*** ./~/react/react.js ***!
  \**************************/

So many comments that I dont need!

[chestozo]

Comments in bundle can result in issues like this one when wrong line number is reported in tools like Sentry
getsentry/sentry-javascript#2550 (comment)