Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contexts created using import() are called System.import context #4270

Closed
simon04 opened this issue Feb 13, 2017 · 1 comment
Closed

Contexts created using import() are called System.import context #4270

simon04 opened this issue Feb 13, 2017 · 1 comment

Comments

@simon04
Copy link
Contributor

simon04 commented Feb 13, 2017

Do you want to request a feature or report a bug?
Bug

What is the current behavior?
Contexts created using import() are called System.import context when running webpack --display-reasons.

If the current behavior is a bug, please provide the steps to reproduce.

  1. cd examples/code-splitting-native-import-context outputs (https://github.com/webpack/webpack/tree/master/examples/code-splitting-native-import-context)
  2. node build.js
  3. webpack outputs (to the console, and to README.md) System.import context ./templates [4] ./example.js 3:23-60

What is the expected behavior?
Since no System.import is used in this example, no System.import context should be mentioned. It should be called import() context or similar.

Please mention other relevant information such as the browser version, Node.js version, webpack version and Operating System.
webpack 2.2.1, node 7.5.0

@sokra
Copy link
Member

sokra commented Feb 13, 2017

yep, that's wrong. Please send a PR.

It's controlled by a static type property on the Dependency. -> lib/dependencies/ImportDependency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants