New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webpack 4.0.0-alpha.2 feedback #6179

Closed
sokra opened this Issue Dec 22, 2017 · 16 comments

Comments

Projects
None yet
6 participants
@sokra
Member

sokra commented Dec 22, 2017

4.0.0-alpha.0
4.0.0-alpha.1

Big features

  • WebAssembly modules can now import other modules (JS and WASM)
  • Exports from WebAssembly modules are validated by ESM import
    • You'll get a warning/error when trying to import a non-existing export from WASM
  • Stats can display modules nested in concatenated modules
  • UglifyJs now caches and parallizes by default

Features

  • Referencing entry point name in import() now emits a error instead of a warning
  • output.hashFunction can now be a Constructor to a custom hash function
    • You can provide a non-cryto hash function for performance reasons
  • Unused modules are no longer unnecessarly concatenated

Bugfixes

  • Using module.id/loaded now correctly bails out of Module Concatentation (Scope Hoisting)
  • OccurenceOrderPlugin now sorts modules in correct order (instead of reversed)

Internal changes

  • Replaced plugin calls with tap calls (new plugin system)

Please comment if you find additional changes not in the changelog

@phyllisstein

This comment has been minimized.

Show comment
Hide comment
@phyllisstein

phyllisstein Dec 28, 2017

Sorry to be a broken record, but wanted to flag that the issue with plugins and MultiCompiler is still extant: #6132 (comment). Good luck continuing to push towards 4.0, I'm excited to see it live!

phyllisstein commented Dec 28, 2017

Sorry to be a broken record, but wanted to flag that the issue with plugins and MultiCompiler is still extant: #6132 (comment). Good luck continuing to push towards 4.0, I'm excited to see it live!

@vincentriemer

This comment has been minimized.

Show comment
Hide comment
@vincentriemer

vincentriemer Dec 29, 2017

Can there be documentation elaborating how the wasm is compiled in the wasm-simple example? I'm having issues loading some of my own wasm and I want to ensure it's not a user error before bringing it forward.

vincentriemer commented Dec 29, 2017

Can there be documentation elaborating how the wasm is compiled in the wasm-simple example? I'm having issues loading some of my own wasm and I want to ensure it's not a user error before bringing it forward.

@phyllisstein

This comment has been minimized.

Show comment
Hide comment
@phyllisstein

phyllisstein Jan 2, 2018

I seem to have stumbled over another error when building for production, this time with what looks like module concatenation:

$ NODE_ENV=production webpack --config=config/webpack/production.js
(node:26) DeprecationWarning: Tapable.plugin is deprecated. Use new API on `.hooks` instead
(node:26) DeprecationWarning: The callback argument was splitted into resolveContext and callback.
(node:26) DeprecationWarning: Tapable.apply is deprecated. Call apply on the plugin directly instead
/usr/src/rupertsberg/node_modules/webpack/lib/dependencies/HarmonyImportSideEffectDependency.js:14
		if(this.module && this.module.factoryMeta.sideEffectFree) return null;
		                                          ^

TypeError: Cannot read property 'sideEffectFree' of undefined
    at HarmonyImportSideEffectDependency.getReference (/usr/src/rupertsberg/node_modules/webpack/lib/dependencies/HarmonyImportSideEffectDependency.js:14:45)
    at Array.from.module.dependencies.filter.map.dep (/usr/src/rupertsberg/node_modules/webpack/lib/optimize/ModuleConcatenationPlugin.js:220:20)
    at Array.map (<anonymous>)
    at ModuleConcatenationPlugin.getImports (/usr/src/rupertsberg/node_modules/webpack/lib/optimize/ModuleConcatenationPlugin.js:220:5)
    at compilation.hooks.optimizeChunkModules.tap (/usr/src/rupertsberg/node_modules/webpack/lib/optimize/ModuleConcatenationPlugin.js:148:28)
    at SyncBailHook.eval [as call] (eval at create (/usr/src/rupertsberg/node_modules/webpack/node_modules/tapable/lib/HookCodeFactory.js:17:12), <anonymous>:13:16)
    at SyncBailHook.lazyCompileHook [as _call] (/usr/src/rupertsberg/node_modules/webpack/node_modules/tapable/lib/Hook.js:35:21)
    at hooks.optimizeTree.callAsync.err (/usr/src/rupertsberg/node_modules/webpack/lib/Compilation.js:763:37)
    at AsyncSeriesHook.eval [as callAsync] (eval at create (/usr/src/rupertsberg/node_modules/webpack/node_modules/tapable/lib/HookCodeFactory.js:24:12), <anonymous>:6:1)
    at AsyncSeriesHook.lazyCompileHook [as _callAsync] (/usr/src/rupertsberg/node_modules/webpack/node_modules/tapable/lib/Hook.js:35:21)
    at Compilation.seal (/usr/src/rupertsberg/node_modules/webpack/lib/Compilation.js:755:27)
    at hooks.make.callAsync.err (/usr/src/rupertsberg/node_modules/webpack/lib/Compiler.js:615:17)
    at _err0 (eval at create (/usr/src/rupertsberg/node_modules/webpack/node_modules/tapable/lib/HookCodeFactory.js:24:12), <anonymous>:11:1)
    at _addModuleChain (/usr/src/rupertsberg/node_modules/webpack/lib/Compilation.js:650:11)
    at processModuleDependencies.err (/usr/src/rupertsberg/node_modules/webpack/lib/Compilation.js:593:8)
    at process._tickCallback (internal/process/next_tick.js:150:11)

Aside from gisting my config, is there any useful detail I can provide about this?

phyllisstein commented Jan 2, 2018

I seem to have stumbled over another error when building for production, this time with what looks like module concatenation:

$ NODE_ENV=production webpack --config=config/webpack/production.js
(node:26) DeprecationWarning: Tapable.plugin is deprecated. Use new API on `.hooks` instead
(node:26) DeprecationWarning: The callback argument was splitted into resolveContext and callback.
(node:26) DeprecationWarning: Tapable.apply is deprecated. Call apply on the plugin directly instead
/usr/src/rupertsberg/node_modules/webpack/lib/dependencies/HarmonyImportSideEffectDependency.js:14
		if(this.module && this.module.factoryMeta.sideEffectFree) return null;
		                                          ^

TypeError: Cannot read property 'sideEffectFree' of undefined
    at HarmonyImportSideEffectDependency.getReference (/usr/src/rupertsberg/node_modules/webpack/lib/dependencies/HarmonyImportSideEffectDependency.js:14:45)
    at Array.from.module.dependencies.filter.map.dep (/usr/src/rupertsberg/node_modules/webpack/lib/optimize/ModuleConcatenationPlugin.js:220:20)
    at Array.map (<anonymous>)
    at ModuleConcatenationPlugin.getImports (/usr/src/rupertsberg/node_modules/webpack/lib/optimize/ModuleConcatenationPlugin.js:220:5)
    at compilation.hooks.optimizeChunkModules.tap (/usr/src/rupertsberg/node_modules/webpack/lib/optimize/ModuleConcatenationPlugin.js:148:28)
    at SyncBailHook.eval [as call] (eval at create (/usr/src/rupertsberg/node_modules/webpack/node_modules/tapable/lib/HookCodeFactory.js:17:12), <anonymous>:13:16)
    at SyncBailHook.lazyCompileHook [as _call] (/usr/src/rupertsberg/node_modules/webpack/node_modules/tapable/lib/Hook.js:35:21)
    at hooks.optimizeTree.callAsync.err (/usr/src/rupertsberg/node_modules/webpack/lib/Compilation.js:763:37)
    at AsyncSeriesHook.eval [as callAsync] (eval at create (/usr/src/rupertsberg/node_modules/webpack/node_modules/tapable/lib/HookCodeFactory.js:24:12), <anonymous>:6:1)
    at AsyncSeriesHook.lazyCompileHook [as _callAsync] (/usr/src/rupertsberg/node_modules/webpack/node_modules/tapable/lib/Hook.js:35:21)
    at Compilation.seal (/usr/src/rupertsberg/node_modules/webpack/lib/Compilation.js:755:27)
    at hooks.make.callAsync.err (/usr/src/rupertsberg/node_modules/webpack/lib/Compiler.js:615:17)
    at _err0 (eval at create (/usr/src/rupertsberg/node_modules/webpack/node_modules/tapable/lib/HookCodeFactory.js:24:12), <anonymous>:11:1)
    at _addModuleChain (/usr/src/rupertsberg/node_modules/webpack/lib/Compilation.js:650:11)
    at processModuleDependencies.err (/usr/src/rupertsberg/node_modules/webpack/lib/Compilation.js:593:8)
    at process._tickCallback (internal/process/next_tick.js:150:11)

Aside from gisting my config, is there any useful detail I can provide about this?

@sokra

This comment has been minimized.

Show comment
Hide comment
@sokra

sokra Jan 2, 2018

Member

@vincentriemer I "compiled" them with this tool: https://cdn.rawgit.com/WebAssembly/wabt/fb986fbd/demo/wat2wasm/

@phyllisstein Could you check with npm ls webpack if there are multiple version of webpack somewhere.

Member

sokra commented Jan 2, 2018

@vincentriemer I "compiled" them with this tool: https://cdn.rawgit.com/WebAssembly/wabt/fb986fbd/demo/wat2wasm/

@phyllisstein Could you check with npm ls webpack if there are multiple version of webpack somewhere.

@vincentriemer

This comment has been minimized.

Show comment
Hide comment
@vincentriemer

vincentriemer Jan 2, 2018

@sokra Ok thanks 🙏, I figured out the issue being that I was compiling via emscripten and it generates a lot of required JS glue code (provided to the wasm via imports) so it seems webpack's wasm loading isn't sufficient for this usecase.

Thanks again for replying!

vincentriemer commented Jan 2, 2018

@sokra Ok thanks 🙏, I figured out the issue being that I was compiling via emscripten and it generates a lot of required JS glue code (provided to the wasm via imports) so it seems webpack's wasm loading isn't sufficient for this usecase.

Thanks again for replying!

@filipesilva

This comment has been minimized.

Show comment
Hide comment
@filipesilva

filipesilva Jan 3, 2018

Contributor

Heya, I tried updating Angular CLI from alpha.0 to alpha.2 and started having this error:

$ ng build
 10% building modules 3/3 modules 0 active(node:1852) DeprecationWarning: Tapable.plugin is deprecated. Use new API on `.hooks` instead
(node:1852) DeprecationWarning: Tapable.apply is deprecated. Call apply on the plugin directly instead
(node:1852) DeprecationWarning: The callback argument was splitted into resolveContext and callback.
D:\work\cli\node_modules\webpack\node_modules\tapable\lib\HookCodeFactory.js:24
                                return new Function(this.args({
                                       ^

RangeError: Maximum call stack size exceeded
    at new Function (<anonymous>)
    at AsyncSeriesBailHookCodeFactory.create (D:\work\cli\node_modules\webpack\node_modules\tapable\lib\HookCodeFactory.js:24:12)
    at AsyncSeriesBailHook.compile (D:\work\cli\node_modules\webpack\node_modules\tapable\lib\AsyncSeriesBailHook.js:31:18)
    at AsyncSeriesBailHook._createCall (D:\work\cli\node_modules\webpack\node_modules\tapable\lib\Hook.js:24:15)
    at AsyncSeriesBailHook.lazyCompileHook (D:\work\cli\node_modules\webpack\node_modules\tapable\lib\Hook.js:34:22)
    at Resolver.doResolve (D:\work\cli\node_modules\webpack\node_modules\enhanced-resolve\lib\Resolver.js:229:16)
    at DescriptionFileUtils.loadDescriptionFile (D:\work\cli\node_modules\webpack\node_modules\enhanced-resolve\lib\DescriptionFilePlugin.js:38:14)
    at forEachBail (D:\work\cli\node_modules\webpack\node_modules\enhanced-resolve\lib\DescriptionFileUtils.js:51:12)
    at D:\work\cli\node_modules\webpack\node_modules\enhanced-resolve\lib\forEachBail.js:31:14
    at onJson (D:\work\cli\node_modules\webpack\node_modules\enhanced-resolve\lib\DescriptionFileUtils.js:42:5)
    at Array.resolver.fileSystem.readJson (D:\work\cli\node_modules\webpack\node_modules\enhanced-resolve\lib\DescriptionFileUtils.js:19:6)
    at Storage.finished (D:\work\cli\node_modules\webpack\node_modules\enhanced-resolve\lib\CachedInputFileSystem.js:43:16)
    at provider (D:\work\cli\node_modules\webpack\node_modules\enhanced-resolve\lib\CachedInputFileSystem.js:79:9)
    at Array.readFile (D:\work\cli\node_modules\webpack\node_modules\enhanced-resolve\lib\CachedInputFileSystem.js:205:6)
    at Storage.finished (D:\work\cli\node_modules\webpack\node_modules\enhanced-resolve\lib\CachedInputFileSystem.js:43:16)
    at provider (D:\work\cli\node_modules\webpack\node_modules\enhanced-resolve\lib\CachedInputFileSystem.js:79:9)
    at D:\work\cli\node_modules\graceful-fs\graceful-fs.js:78:16
    at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:511:3)

Not really sure what's going wrong or how to find the problem. Does this error ring a bell to anyone?

Contributor

filipesilva commented Jan 3, 2018

Heya, I tried updating Angular CLI from alpha.0 to alpha.2 and started having this error:

$ ng build
 10% building modules 3/3 modules 0 active(node:1852) DeprecationWarning: Tapable.plugin is deprecated. Use new API on `.hooks` instead
(node:1852) DeprecationWarning: Tapable.apply is deprecated. Call apply on the plugin directly instead
(node:1852) DeprecationWarning: The callback argument was splitted into resolveContext and callback.
D:\work\cli\node_modules\webpack\node_modules\tapable\lib\HookCodeFactory.js:24
                                return new Function(this.args({
                                       ^

RangeError: Maximum call stack size exceeded
    at new Function (<anonymous>)
    at AsyncSeriesBailHookCodeFactory.create (D:\work\cli\node_modules\webpack\node_modules\tapable\lib\HookCodeFactory.js:24:12)
    at AsyncSeriesBailHook.compile (D:\work\cli\node_modules\webpack\node_modules\tapable\lib\AsyncSeriesBailHook.js:31:18)
    at AsyncSeriesBailHook._createCall (D:\work\cli\node_modules\webpack\node_modules\tapable\lib\Hook.js:24:15)
    at AsyncSeriesBailHook.lazyCompileHook (D:\work\cli\node_modules\webpack\node_modules\tapable\lib\Hook.js:34:22)
    at Resolver.doResolve (D:\work\cli\node_modules\webpack\node_modules\enhanced-resolve\lib\Resolver.js:229:16)
    at DescriptionFileUtils.loadDescriptionFile (D:\work\cli\node_modules\webpack\node_modules\enhanced-resolve\lib\DescriptionFilePlugin.js:38:14)
    at forEachBail (D:\work\cli\node_modules\webpack\node_modules\enhanced-resolve\lib\DescriptionFileUtils.js:51:12)
    at D:\work\cli\node_modules\webpack\node_modules\enhanced-resolve\lib\forEachBail.js:31:14
    at onJson (D:\work\cli\node_modules\webpack\node_modules\enhanced-resolve\lib\DescriptionFileUtils.js:42:5)
    at Array.resolver.fileSystem.readJson (D:\work\cli\node_modules\webpack\node_modules\enhanced-resolve\lib\DescriptionFileUtils.js:19:6)
    at Storage.finished (D:\work\cli\node_modules\webpack\node_modules\enhanced-resolve\lib\CachedInputFileSystem.js:43:16)
    at provider (D:\work\cli\node_modules\webpack\node_modules\enhanced-resolve\lib\CachedInputFileSystem.js:79:9)
    at Array.readFile (D:\work\cli\node_modules\webpack\node_modules\enhanced-resolve\lib\CachedInputFileSystem.js:205:6)
    at Storage.finished (D:\work\cli\node_modules\webpack\node_modules\enhanced-resolve\lib\CachedInputFileSystem.js:43:16)
    at provider (D:\work\cli\node_modules\webpack\node_modules\enhanced-resolve\lib\CachedInputFileSystem.js:79:9)
    at D:\work\cli\node_modules\graceful-fs\graceful-fs.js:78:16
    at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:511:3)

Not really sure what's going wrong or how to find the problem. Does this error ring a bell to anyone?

@sokra

This comment has been minimized.

Show comment
Hide comment
@sokra

sokra Jan 3, 2018

Member

@filipesilva It doesn't ring for me. You should run this with debugger attached to inspect some variables. Call stack doesn't look deep to me...

Member

sokra commented Jan 3, 2018

@filipesilva It doesn't ring for me. You should run this with debugger attached to inspect some variables. Call stack doesn't look deep to me...

@HipsterZipster

This comment has been minimized.

Show comment
Hide comment
@HipsterZipster

HipsterZipster Jan 4, 2018

Which typescript loader options are compatible with this release of 4.0.0-alpha.2?

HipsterZipster commented Jan 4, 2018

Which typescript loader options are compatible with this release of 4.0.0-alpha.2?

@filipesilva

This comment has been minimized.

Show comment
Hide comment
@filipesilva

filipesilva Jan 4, 2018

Contributor

@sokra thanks for the tip. After messing around with the debugger and some console.logs for a bit turns out it was the RxJS path mapping alias: https://unpkg.com/rxjs@5.5.2/_esm5/path-mapping

They are used in the webpack config resolve object this way: https://github.com/ReactiveX/rxjs/blob/master/doc/lettable-operators.md#build-and-treeshaking.

Is this perhaps related to Moved Compiler.resolvers into Compiler.resolverFactory accessible with plugins. in #6064?

Contributor

filipesilva commented Jan 4, 2018

@sokra thanks for the tip. After messing around with the debugger and some console.logs for a bit turns out it was the RxJS path mapping alias: https://unpkg.com/rxjs@5.5.2/_esm5/path-mapping

They are used in the webpack config resolve object this way: https://github.com/ReactiveX/rxjs/blob/master/doc/lettable-operators.md#build-and-treeshaking.

Is this perhaps related to Moved Compiler.resolvers into Compiler.resolverFactory accessible with plugins. in #6064?

@filipesilva filipesilva referenced this issue Jan 4, 2018

Closed

fix(@angular/cli): use webpack 4 #8611

2 of 14 tasks complete
@sokra

This comment has been minimized.

Show comment
Hide comment
@sokra

sokra Jan 4, 2018

Member

@filipesilva ah I see. That's a problem in enhanced-resolve.

Member

sokra commented Jan 4, 2018

@filipesilva ah I see. That's a problem in enhanced-resolve.

@sokra

This comment has been minimized.

Show comment
Hide comment
Member

sokra commented Jan 4, 2018

@filipesilva

This comment has been minimized.

Show comment
Hide comment
@filipesilva

filipesilva Jan 4, 2018

Contributor

@sokra I think there might be a problem with that fix, I tried using 4.0.0-beta.3 and now I get this:

 10% building modules 3/3 modules 0 active(node:4384) DeprecationWarning: Tapable.plugin is deprecated. Use new API on `.hooks` instead
(node:4384) DeprecationWarning: Tapable.apply is deprecated. Call apply on the plugin directly instead
(node:4384) DeprecationWarning: The callback argument was splitted into resolveContext and callback.
D:\work\cli\node_modules\webpack\node_modules\enhanced-resolve\lib\AliasPlugin.js:36
                        for(const item of this.options) {
                                               ^

TypeError: this.options is not iterable
    at resolver.getHook.tapAsync (D:\work\cli\node_modules\webpack\node_modules\enhanced-resolve\lib\AliasPlugin.js:36:27)
    at _fn0 (eval at create (D:\work\cli\node_modules\webpack\node_modules\tapable\lib\HookCodeFactory.js:24:12), <anonymous>:16:1)
    at resolver.getHook.tapAsync (D:\work\cli\node_modules\webpack\node_modules\enhanced-resolve\lib\AliasFieldPlugin.js:26:12)
    at AsyncSeriesBailHook.eval [as callAsync] (eval at create (D:\work\cli\node_modules\webpack\node_modules\tapable\lib\HookCodeFactory.js:24:12), <anonymous>:7:1)
    at AsyncSeriesBailHook.lazyCompileHook [as _callAsync] (D:\work\cli\node_modules\webpack\node_modules\tapable\lib\Hook.js:35:21)
    at Resolver.doResolve (D:\work\cli\node_modules\webpack\node_modules\enhanced-resolve\lib\Resolver.js:229:16)
    at DescriptionFileUtils.loadDescriptionFile (D:\work\cli\node_modules\webpack\node_modules\enhanced-resolve\lib\DescriptionFilePlugin.js:38:14)
    at forEachBail (D:\work\cli\node_modules\webpack\node_modules\enhanced-resolve\lib\DescriptionFileUtils.js:51:12)
    at D:\work\cli\node_modules\webpack\node_modules\enhanced-resolve\lib\forEachBail.js:31:14
    at onJson (D:\work\cli\node_modules\webpack\node_modules\enhanced-resolve\lib\DescriptionFileUtils.js:42:5)
    at Array.resolver.fileSystem.readJson (D:\work\cli\node_modules\webpack\node_modules\enhanced-resolve\lib\DescriptionFileUtils.js:19:6)
    at Storage.finished (D:\work\cli\node_modules\webpack\node_modules\enhanced-resolve\lib\CachedInputFileSystem.js:43:16)
    at provider (D:\work\cli\node_modules\webpack\node_modules\enhanced-resolve\lib\CachedInputFileSystem.js:79:9)
    at Array.readFile (D:\work\cli\node_modules\webpack\node_modules\enhanced-resolve\lib\CachedInputFileSystem.js:205:6)
    at Storage.finished (D:\work\cli\node_modules\webpack\node_modules\enhanced-resolve\lib\CachedInputFileSystem.js:43:16)
    at provider (D:\work\cli\node_modules\webpack\node_modules\enhanced-resolve\lib\CachedInputFileSystem.js:79:9)
    at D:\work\cli\node_modules\webpack\node_modules\graceful-fs\graceful-fs.js:78:16
    at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:511:3)
Contributor

filipesilva commented Jan 4, 2018

@sokra I think there might be a problem with that fix, I tried using 4.0.0-beta.3 and now I get this:

 10% building modules 3/3 modules 0 active(node:4384) DeprecationWarning: Tapable.plugin is deprecated. Use new API on `.hooks` instead
(node:4384) DeprecationWarning: Tapable.apply is deprecated. Call apply on the plugin directly instead
(node:4384) DeprecationWarning: The callback argument was splitted into resolveContext and callback.
D:\work\cli\node_modules\webpack\node_modules\enhanced-resolve\lib\AliasPlugin.js:36
                        for(const item of this.options) {
                                               ^

TypeError: this.options is not iterable
    at resolver.getHook.tapAsync (D:\work\cli\node_modules\webpack\node_modules\enhanced-resolve\lib\AliasPlugin.js:36:27)
    at _fn0 (eval at create (D:\work\cli\node_modules\webpack\node_modules\tapable\lib\HookCodeFactory.js:24:12), <anonymous>:16:1)
    at resolver.getHook.tapAsync (D:\work\cli\node_modules\webpack\node_modules\enhanced-resolve\lib\AliasFieldPlugin.js:26:12)
    at AsyncSeriesBailHook.eval [as callAsync] (eval at create (D:\work\cli\node_modules\webpack\node_modules\tapable\lib\HookCodeFactory.js:24:12), <anonymous>:7:1)
    at AsyncSeriesBailHook.lazyCompileHook [as _callAsync] (D:\work\cli\node_modules\webpack\node_modules\tapable\lib\Hook.js:35:21)
    at Resolver.doResolve (D:\work\cli\node_modules\webpack\node_modules\enhanced-resolve\lib\Resolver.js:229:16)
    at DescriptionFileUtils.loadDescriptionFile (D:\work\cli\node_modules\webpack\node_modules\enhanced-resolve\lib\DescriptionFilePlugin.js:38:14)
    at forEachBail (D:\work\cli\node_modules\webpack\node_modules\enhanced-resolve\lib\DescriptionFileUtils.js:51:12)
    at D:\work\cli\node_modules\webpack\node_modules\enhanced-resolve\lib\forEachBail.js:31:14
    at onJson (D:\work\cli\node_modules\webpack\node_modules\enhanced-resolve\lib\DescriptionFileUtils.js:42:5)
    at Array.resolver.fileSystem.readJson (D:\work\cli\node_modules\webpack\node_modules\enhanced-resolve\lib\DescriptionFileUtils.js:19:6)
    at Storage.finished (D:\work\cli\node_modules\webpack\node_modules\enhanced-resolve\lib\CachedInputFileSystem.js:43:16)
    at provider (D:\work\cli\node_modules\webpack\node_modules\enhanced-resolve\lib\CachedInputFileSystem.js:79:9)
    at Array.readFile (D:\work\cli\node_modules\webpack\node_modules\enhanced-resolve\lib\CachedInputFileSystem.js:205:6)
    at Storage.finished (D:\work\cli\node_modules\webpack\node_modules\enhanced-resolve\lib\CachedInputFileSystem.js:43:16)
    at provider (D:\work\cli\node_modules\webpack\node_modules\enhanced-resolve\lib\CachedInputFileSystem.js:79:9)
    at D:\work\cli\node_modules\webpack\node_modules\graceful-fs\graceful-fs.js:78:16
    at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:511:3)
@drejohnson

This comment has been minimized.

Show comment
Hide comment
@drejohnson

drejohnson Jan 4, 2018

I have the same issue as @filipesilva

drejohnson commented Jan 4, 2018

I have the same issue as @filipesilva

@sokra

This comment has been minimized.

Show comment
Hide comment
@sokra

sokra Jan 4, 2018

Member

hmm... yeah, I'll fix it

Member

sokra commented Jan 4, 2018

hmm... yeah, I'll fix it

@sokra

This comment has been minimized.

Show comment
Hide comment
@sokra

sokra Jan 4, 2018

Member

hopefully it's fixed now

Member

sokra commented Jan 4, 2018

hopefully it's fixed now

@sokra

This comment has been minimized.

Show comment
Hide comment
@sokra

sokra Jan 4, 2018

Member

continue testing here: #6244

Member

sokra commented Jan 4, 2018

continue testing here: #6244

@sokra sokra closed this Jan 4, 2018

@webpack webpack locked as resolved and limited conversation to collaborators Jan 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.