New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #10677
Update README.md #10677
Conversation
|
For maintainers only:
|
Hi @chaytanyasinha. Just a little hint from a friendly bot about the best practice when submitting pull requests:
You don't have to change it for this PR, just make sure to follow this hint the next time you submit a PR. |
@chaytanyasinha Thanks for your update. I labeled the Pull Request so reviewers will review it again. @sokra Please review the new changes. |
@sokra I have updated the pull request.Please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI failed, fix it first
@himanshu010 Can you please help me with that,I have tried to do but it's not working. |
I think you forget to run prettier If prettier is not installed, then install it first using: yarn global add prettier |
@rishabh3112 Please review |
please reopen your PR for review |
@snitin315 actually because of CI failure even after running all the commands I closed this and thought of adding another request |
@chaytanyasinha The most important CI builds failed. This way your PR can't be merged. Please take a look at the CI results from travis (failure) and appveyor (success) and fix these issues. |
your branch is too much outdated from upstream (297 commits behind).
then make your changes again, commit and force push the changes.
|
It looks like you pushed before making new changes and commiting them. |
@snitin315 yeah by mistake |
now you can push your changes again and open PR. |
@snitin315 I am trying but |
You need to fix those errors first. |
Is it because of prettier? |
Pre commit hook automatically run prettier/lint for you before each commit. When some errors are not fixable automatically then you have to fix them manually. |
Okay @snitin315 ,were these problems faced by you too while setting up? |
No |
What kind of change does this PR introduce?
fix
currently, the README.md doesn't have important thing that should have been mentioned for webpack as a JavaScript module bundler.
Did you add tests for your changes?
NA
Does this PR introduce a breaking change?
NO,but will help the new user to learn more about webpack.
What needs to be documented once your changes are merged?
Nothing.