Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #10677

Closed
wants to merge 0 commits into from
Closed

Update README.md #10677

wants to merge 0 commits into from

Conversation

chaytanyasinha
Copy link

What kind of change does this PR introduce?
fix

currently, the README.md doesn't have important thing that should have been mentioned for webpack as a JavaScript module bundler.

Did you add tests for your changes?
NA

Does this PR introduce a breaking change?
NO,but will help the new user to learn more about webpack.

What needs to be documented once your changes are merged?
Nothing.

@jsf-clabot
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@webpack-bot
Copy link
Contributor

Hi @chaytanyasinha.

Just a little hint from a friendly bot about the best practice when submitting pull requests:

Don't submit pull request from your own master branch. It's recommended to create a feature branch for the PR.

You don't have to change it for this PR, just make sure to follow this hint the next time you submit a PR.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@webpack-bot
Copy link
Contributor

@chaytanyasinha Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@sokra Please review the new changes.

@chaytanyasinha
Copy link
Author

@sokra I have updated the pull request.Please review.

Copy link
Contributor

@himanshu010 himanshu010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failed, fix it first

@chaytanyasinha
Copy link
Author

@himanshu010 Can you please help me with that,I have tried to do but it's not working.

@himanshu010
Copy link
Contributor

I think you forget to run prettier
run the command: yarn pretty-lint-fix

If prettier is not installed, then install it first using: yarn global add prettier
And then run that command

@chaytanyasinha
Copy link
Author

@rishabh3112 Please review

@snitin315
Copy link
Member

please reopen your PR for review

@chaytanyasinha chaytanyasinha reopened this Apr 9, 2020
@chaytanyasinha
Copy link
Author

@snitin315 actually because of CI failure even after running all the commands I closed this and thought of adding another request

@webpack-bot
Copy link
Contributor

@chaytanyasinha The most important CI builds failed. This way your PR can't be merged.

Please take a look at the CI results from travis (failure) and appveyor (success) and fix these issues.

@snitin315
Copy link
Member

your branch is too much outdated from upstream (297 commits behind).
First, you need to reset your branch with upstream.

git remote add upstream git@github.com:webpack/webpack.git
git fetch upstream master
git reset --hard upstream/master

then make your changes again, commit and force push the changes.

git push origin master --force

@snitin315
Copy link
Member

It looks like you pushed before making new changes and commiting them.

@chaytanyasinha
Copy link
Author

@snitin315 yeah by mistake

@snitin315
Copy link
Member

now you can push your changes again and open PR.

@chaytanyasinha
Copy link
Author

@snitin315 I am trying but
'' 32 problems (32 errors, 0 warnings)
husky > pre-commit hook failed (add --no-verify to bypass)''
this error is comming

@snitin315
Copy link
Member

You need to fix those errors first.

@chaytanyasinha
Copy link
Author

Is it because of prettier?

@snitin315
Copy link
Member

Pre commit hook automatically run prettier/lint for you before each commit. When some errors are not fixable automatically then you have to fix them manually.

@chaytanyasinha
Copy link
Author

Okay @snitin315 ,were these problems faced by you too while setting up?

@snitin315
Copy link
Member

No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants