Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor hashFunction option for createFileSerializer #14557

Merged
merged 2 commits into from
Oct 24, 2021

Conversation

JonnyBurger
Copy link
Contributor

In addition to the main breakage of Node.JS 17, we also experienced this one:
Caching fails because the hashing function for serializing being used is always the default one.

Changing it so that the hash function also gets passed to createFileSerializer() which accepts a second parameter, the hash function. Using that change, I was able to change the hash function in my webpack config and get filesystem caching working on Node 17 without any errors.

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 24, 2021

CLA Signed

The committers are authorized under a signed CLA.

@alexander-akait
Copy link
Member

Please fix CI errors

@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@sokra sokra merged commit b865ecb into webpack:main Oct 24, 2021
@sokra
Copy link
Member

sokra commented Oct 24, 2021

Thanks for fixing that oversight

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants