Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show which singleton loaded version #14782

Conversation

@tanhauhau
Copy link
Contributor

@tanhauhau tanhauhau commented Nov 21, 2021

closes #13020

What kind of change does this PR introduce?

Add more info to the invalid singleton version error message

Did you add tests for your changes?

Does this PR introduce a breaking change?

What needs to be documented once your changes are merged?

@webpack-bot
Copy link
Contributor

@webpack-bot webpack-bot commented Nov 21, 2021

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

vankop
vankop approved these changes Nov 22, 2021
@webpack-bot
Copy link
Contributor

@webpack-bot webpack-bot commented Nov 25, 2021

@sokra Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@vankop Please review the new changes.

sokra
sokra approved these changes Nov 25, 2021
@sokra sokra merged commit ac9a2c8 into webpack:main Nov 25, 2021
38 of 47 checks passed
@sokra
Copy link
Member

@sokra sokra commented Nov 25, 2021

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants