Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix and test module federation with ESM #14827

Merged
merged 3 commits into from Nov 25, 2021
Merged

fix and test module federation with ESM #14827

merged 3 commits into from Nov 25, 2021

Conversation

@sokra
Copy link
Member

@sokra sokra commented Nov 25, 2021

This fixes the problems when using:

experiments: {
	outputModule: true
},
plugins: [
	new ModuleFederationPlugin({
		library: { type: "module" },
		...

What kind of change does this PR introduce?
bugfix

Did you add tests for your changes?
yes

Does this PR introduce a breaking change?
no

What needs to be documented once your changes are merged?
nothing

@webpack-bot
Copy link
Contributor

@webpack-bot webpack-bot commented Nov 25, 2021

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@sokra sokra merged commit 093eadf into main Nov 25, 2021
45 of 47 checks passed
@sokra sokra deleted the bugfix/mf-module branch Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants