Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(util): added jsdoc annotations for ArrayHelpers.js #15279

Merged
merged 1 commit into from Jan 31, 2022

Conversation

taranek
Copy link
Contributor

@taranek taranek commented Jan 30, 2022

Hi there, it's my first contribution to this repo, so I tried to find something easy to make my debut smoother. I hope I won't break contribution guidelines馃

What kind of change does this PR introduce?

Adds missing JSDoc type annotations for util/ArrayHelpers.js file.
Improves type safety of groupBy and equals util methods by providing an optional type parameter representing the type of a single array element (which defaults to any).

Did you add tests for your changes?

No.

Does this PR introduce a breaking change?

No.

What needs to be documented once your changes are merged?

Nothing - it's just a small improvement of the existing documentation.

@linux-foundation-easycla
Copy link

@linux-foundation-easycla linux-foundation-easycla bot commented Jan 30, 2022

CLA Signed

The committers are authorized under a signed CLA.

@webpack-bot
Copy link
Contributor

@webpack-bot webpack-bot commented Jan 30, 2022

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@taranek taranek force-pushed the docs/array-helpers-docs branch from 3cf3f49 to c13e088 Compare Jan 30, 2022
@taranek taranek force-pushed the docs/array-helpers-docs branch from c13e088 to 5a3760e Compare Jan 30, 2022
sokra
sokra approved these changes Jan 31, 2022
@sokra sokra merged commit 6f3735c into webpack:main Jan 31, 2022
45 of 47 checks passed
@sokra
Copy link
Member

@sokra sokra commented Jan 31, 2022

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants