Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I want to resolve#16045 , I made relevant changes mentioned in the issue. let me know if any additional changes are required #16122

Merged
merged 1 commit into from Nov 9, 2022
Merged

I want to resolve#16045 , I made relevant changes mentioned in the issue. let me know if any additional changes are required #16122

merged 1 commit into from Nov 9, 2022

Conversation

AnmolBansalDEV
Copy link
Contributor

@AnmolBansalDEV AnmolBansalDEV commented Aug 6, 2022 •
edited

resolves #16045
I implemented the issue and solution mentioned in the issue

What kind of change does this PR introduce?
a bugfix

Did you add tests for your changes?
no

Does this PR introduce a breaking change?

What needs to be documented once your changes are merged?

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 6, 2022 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: AnmolBansalDEV / name: Anmol Bansal (828722d)

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@AnmolBansalDEV
Copy link
Contributor Author

hey, are any more changes required?

@alexander-akait
Copy link
Member

All is fine 👍

@AnmolBansalDEV
Copy link
Contributor Author

Oh, then when will it be merged?

@alexander-akait
Copy link
Member

In near future

@AnmolBansalDEV
Copy link
Contributor Author

hey, can you please add hacktoberfest tag and merge the PR. Thank you!

@sokra sokra merged commit dfdd0b0 into webpack:main Nov 9, 2022
47 checks passed
@sokra
Copy link
Member

sokra commented Nov 9, 2022

Thanks

@AnmolBansalDEV
Copy link
Contributor Author

No problem!! I'll appreciate more such beginner friendly issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees
No one assigned
Labels
PR: reviewed-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compilation._handleModuleBuildAndDependencies's callback should get module when no error happening.
4 participants
@AnmolBansalDEV @webpack-bot @alexander-akait @sokra