/ webpack Public
perf: remove assignDeterministic verbose Math.ceil code to improve performance #16257
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
What kind of change does this PR introduce?
Did you add tests for your changes?
Does this PR introduce a breaking change?
What needs to be documented once your changes are merged?
Introduce about this PR
The old code about assignDeterministicIds fill rate is:
but in this PR, it changed to
itemsis an array, and its length will never be a decimal. So it's not necessary to add
Math.ceilto improve the performance.
And this change will not cause any Breaking Change, I ran all tests.