/ webpack Public
Respect output.hashSalt in RealContentHashPlugin #16789
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
RealContentHashPluginto initialize hash instances with the value of
output.hashSalt, if provided. This allows developers to use the
output.hashSaltproperty to force all emitted webpack assets to have new hashes, even though the content has not changed, for example to deliberately cache break a CDN.
Note that if the
optimization.realContentHashproperty was set to
false, the value of
output.hashSaltin the calculation.
What kind of change does this PR introduce?
Did you add tests for your changes?
Yes. Changes verify that running three configs with identical source files and two different values of
output.hashSaltproduce exactly 2 unique output hashes.
Does this PR introduce a breaking change?
This could be considered a breaking change if a consumer is using the
output.hashSaltproperty and depending on the value of
[contenthash]not changing when
Plugins that provide a custom implementation of the content hash (e.g. for Sub-Resource Integrity) will not be impacted, because this change only applies when the
RealContentHashPluginis the entity that generates the content hash.
What needs to be documented once your changes are merged?
optimization.realContentHashshould be updated to explicitly call out that it does include
output.hashSaltif set. The current state of the documentation is unclear on whether or not it is expected.