Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Improve performance of hashRegExp lookup" #16803


Copy link

Reverts #16759

Discussion here: #16759 (comment)

Performance benchmarks showing the improvement were calculated on an M1 Macbook Pro, subsequent performance benchmarks performed on more powerful machines running an Intel architecture show a substantial regression from these changes. I'd suggest that we revert this feature and cut a patch release.

Copy link

For maintainers only:

  • This needs to be documented (issue in webpack/ will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

Copy link

@TheLarkInn Let's do small patch release

Copy link

Sounds great! Go ahead @alexander-akait.

@TheLarkInn TheLarkInn merged commit e76ad9e into webpack:main Mar 10, 2023
45 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

4 participants