adding yarn lock file and removing it from git ignore #3648

Merged
merged 3 commits into from Dec 30, 2016

Projects

None yet

4 participants

@elodszopos
Contributor
elodszopos commented Dec 30, 2016 edited

Removes yarn.lock from under git ignore and adds the lock file with current dependencies.

Did you add tests for your changes?

Not necessary.

If relevant, link to documentation update:

Closes #3606.

Summary

After all, we don't want to make @thejameskyle mad. And Mr. Travis likes lock files too.

Does this PR introduce a breaking change?

No breakage.

Other information

Should I maybe also add yarn as a dev dependency or we prefer people globally install it?

@elodszopos elodszopos adding yarn lock file and removing it from git ignore
55c0001
@SpaceK33z
Member
SpaceK33z commented Dec 30, 2016 edited

Could you change the Travis file too? It can be simplified a bit. Here is the documentation about that.

@elodszopos
Contributor

@SpaceK33z - which part do you think could be made simpler?

We have the caching enabled.

Do we need the before_install hook, still? I could possibly remove that.

Also - our instal script on travis does the following:

npm install yarn -g && yarn install && yarn link || true && yarn link webpack;

which should install yarn globally, then install dependencies and then link webpack.

@SpaceK33z
Member
SpaceK33z commented Dec 30, 2016 edited

Manually installing Yarn is not necessary anymore, Travis will install it automatically when the repo has a yarn.lock file. See this documentation page for more info. So we'll only need the yarn link || true && yarn link webpack thingy.

elodszopos added some commits Dec 30, 2016
@elodszopos elodszopos simplify Travis for yarn flow
0b55967
@elodszopos elodszopos try moving yarn link to after travis installs yarn
a10b113
@elodszopos
Contributor

All done. Coverage related tests seem to be failing across the board for some reason. Not just this PR, but a previous one too. Thanks for the assistance @SpaceK33z.

@sokra
Member
sokra commented Dec 30, 2016

Coverage takes a bit to be up-to-date. OSX builds are optional and take a while to complete.

@TheLarkInn TheLarkInn merged commit bfcc594 into webpack:master Dec 30, 2016

7 checks passed

codecov/changes No unexpected coverage changes found.
Details
codecov/patch Coverage not affected when comparing d3bb9c4...a10b113
Details
codecov/project 91.42% (+0.00%) compared to d3bb9c4
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 91.779%
Details
licence/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment